Fix: Board card never actually hid (CSS specificity beat [hidden]) - #5
Merged
Conversation
…ually hides The #2 data-optional wiring set hidden=true in JS, but .metric{display:flex} (class specificity 0,1,0) beat the UA [hidden] default (0,0,0), so the Board card stayed visible with a dead --deg on the live NAS. Add a global [hidden]{display:none!important} rule + a UI-contract regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4. The data-optional Board card set hidden=true in JS but stayed visible on the live NAS: .metric{display:flex} (specificity 0,1,0) beat the UA [hidden] default (0,0,0). Screenshot of the deployed page caught it. Fix: global [hidden]{display:none!important} + UI-contract regression test. 50 tests green.