Skip to content

smooth-change #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KapToH337 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

smooth-change #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85afded
solution
Apr 5, 2021
c0f2b06
solution
Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/styles/block/card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,20 @@
border-radius: 5px;

&__img {
margin: 29px 19px 0;
margin: 29px 19px 45px;
width: 160px;
height: 134px;
transition-duration: 0.4s;
transition-property: transform;
}

&__img:hover {
transform: scale(1.2);
outline: 3px solid #f3f3f3;

@victor-arutiunov victor-arutiunov Apr 6, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires use border. But it`s also good solution.

}

&__name {
margin: 45px 0 0 14px;
margin: 0 0 0 14px;

@victor-arutiunov victor-arutiunov Apr 6, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write just "margin-bottom: 14px;".

font-weight: 500;
font-size: 12px;
line-height: 15px;
Expand Down Expand Up @@ -65,6 +72,8 @@
background-color: $light-blue-color;
border: 1px solid $light-blue-color;
border-radius: 5px;
transition-duration: 0.4s;

@aionova aionova Apr 6, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include what exactly you use transition for (transform, color, etc.)

transition-property: all;
}

&__buy:hover {
Expand Down
2 changes: 2 additions & 0 deletions src/styles/block/nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
text-transform: uppercase;
text-decoration: none;
color: #000;
transition-duration: 0.4s;
transition-property: all;
}

&__link:hover {
Expand Down