smooth-change#2
Open
KapToH337 wants to merge 2 commits into
Open
Conversation
| padding: 8px 6px; | ||
| width: 100%; | ||
| height: 100%; | ||
| outline: 3px solid #f3f3f3; |
There was a problem hiding this comment.
The task requires use border. But it`s also good solution.
|
|
||
| &__name { | ||
| margin: 45px 0 0 14px; | ||
| margin: 0 0 0 14px; |
There was a problem hiding this comment.
You can write just "margin-bottom: 14px;".
aionova
suggested changes
Apr 6, 2021
| } | ||
|
|
||
| &__img:hover { | ||
| margin: 0 0 37px; |
There was a problem hiding this comment.
don't animate width, height, margins and paddings. Use transform scale for changing size and change border-color.
https://pqina.nl/blog/animating-width-and-height-without-the-squish-effect/
| background-color: $light-blue-color; | ||
| border: 1px solid $light-blue-color; | ||
| border-radius: 5px; | ||
| transition-duration: 0.4s; |
There was a problem hiding this comment.
include what exactly you use transition for (transform, color, etc.)
aionova
approved these changes
Apr 6, 2021
aionova
left a comment
aionova
left a comment
There was a problem hiding this comment.
Indicate what exact properties you use transition for. Don't use transition: all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK