Skip to content

SCENARIO: Image names may contain special character (see #360). #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benel merged 3 commits into from
May 27, 2026
Merged

SCENARIO: Image names may contain special character (see #360). #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8692c4f
SCENARIO: Image names may contain special character (see #360).
CocoChart Mar 31, 2026
7208656
TEST: Image names may contain special character (see #360).
aminssutt Apr 21, 2026
b19f94d
FIX: Image names may contain special character (fixes #360)
Engu-s May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added docs/#1architecture.png
View file
Open in desktop
Comment thread
CocoChart marked this conversation as resolved.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions frontend/scenarios/add_picture.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ Fonctionnalité: Ajouter une image à une glose

Soit un document dont je suis l'auteur affiché comme glose
Et une session active avec mon compte
Quand j'essaie d'ajouter une image à une glose
Alors je vois l'image "<IMAGE DESCRIPTION>" dans la glose
Quand j'essaie d'ajouter une image "#1architecture.png" à une glose
Alors je vois l'image "#1architecture.png" dans la glose
Et l'image a un texte alternatif "<IMAGE DESCRIPTION>"
3 changes: 1 addition & 2 deletions frontend/src/hyperglosae.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ function Hyperglosae(logger) {
reader.readAsArrayBuffer(attachment);
reader.onload = () => {
const arrayBuffer = reader.result;

fetch(`${service}/${id}/${attachment.name}`, {
fetch(`${service}/${id}/${attachment.name.replaceAll('#', '%23')}`, {
method: 'PUT',
headers: {
// ETag is the header that carries the current rev.
Expand Down
4 changes: 2 additions & 2 deletions frontend/tests/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ Quand("je supprime le lien entre le document principal et la référence", () =>
cy.get(".modal-dialog").get(".btn-primary").click();
});

Quand("j'essaie d'ajouter une image à une glose", () => {
Quand("j'essaie d'ajouter une image {string} à une glose", (imagePath) => {
context = cy.get('.scholium').eq(1);
cy.click_on_contextual_menu_item(context, 'Add a picture...');
cy.get('[id="image-input"]').selectFile('../docs/architecture.png', {
cy.get('[id="image-input"]').selectFile(`../docs/${imagePath}`, {
force: true,
});
});
Expand Down
10 changes: 8 additions & 2 deletions frontend/tests/outcome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@ Alors("je ne peux pas lire {string}", (text) => {
cy.get('body').should('not.contain', text);
});

Alors("je vois l'image {string} dans la glose", (alternative_text) => {
cy.get('.row:not(.runningHead)>.scholium').should('have.descendants', `img[alt='${alternative_text}']`);
Alors("je vois l'image {string} dans la glose", (image_name) => {
cy.get('.row:not(.runningHead)>.scholium img[src]')
.invoke('attr', 'src')
.should('match', /^http.*:\/\/(?!.*\/#).*/)
});

Alors("l'image a un texte alternatif {string}", (alternative_text) => {
cy.get('.row:not(.runningHead)>.scholium').should('have.descendants', `img[alt='${alternative_text}']`);
});

Alors("je vois l'image {string} dans le document principal", (alternative_text) => {
Expand Down
Loading