Skip to content

SCENARIO: Image names may contain special character (see #360).#410

Merged
benel merged 3 commits into
mainfrom
fix-360
May 27, 2026
Merged

SCENARIO: Image names may contain special character (see #360).#410
benel merged 3 commits into
mainfrom
fix-360

Conversation

@CocoChart
Copy link
Copy Markdown
Collaborator

@CocoChart CocoChart commented Mar 31, 2026

Co-authored-by:
Enguerrand LUCAT @Engu-s
Lakhdar Berache @aminssutt

We hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

@CocoChart CocoChart force-pushed the fix-360 branch 6 times, most recently from d122b87 to 7a4aec4 Compare March 31, 2026 15:31
benel
benel requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CocoChart @Engu-s @aminssutt for your contribution.

Comment thread frontend/scenarios/add_picture.feature Outdated
@aminssutt aminssutt force-pushed the fix-360 branch 2 times, most recently from 791c4ff to f1e5be3 Compare April 21, 2026 14:20
@benel
Copy link
Copy Markdown
Member

benel commented Apr 28, 2026

Hmm, the test pass although the software behavior is not fixed yet... 🤔

@CocoChart
Copy link
Copy Markdown
Collaborator Author

CocoChart commented Apr 28, 2026

Hmm, the test pass although the software behavior is not fixed yet... 🤔

@benel The problem is that the bug only occurs when the name of the image has a special character, which means it is a specific value of the string parameter in the scenario.
Should we add a scenario and test for this specific value, or change the existing ones with a parameter that makes the test fail ?

@Engu-s Engu-s force-pushed the fix-360 branch 2 times, most recently from f8aa91d to a67383f Compare May 12, 2026 14:17
@CocoChart CocoChart marked this pull request as ready for review May 12, 2026 14:45
benel
benel requested changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CocoChart @Engu-s @aminssutt for your updates.

Please have a look at the comments below.

Comment thread docs/#1architecture.png
Comment thread frontend/scenarios/add_picture.feature Outdated
Comment thread frontend/src/hyperglosae.js Outdated
@CocoChart CocoChart force-pushed the fix-360 branch 5 times, most recently from 84cfc72 to ffaef75 Compare May 26, 2026 14:41
CocoChart and others added 3 commits May 27, 2026 16:27
@CocoChart @Engu-s
@aminssutt @benel
SCENARIO: Image names may contain special character (see #360).
8692c4f 
Co-authored-by: Enguerrand LUCAT <enguerrand.lucat@gmail.com>
Co-authored-by: Lakhdar Berache <lakhdar.berache@utt.fr>
@aminssutt @benel
TEST: Image names may contain special character (see #360).
7208656 
Co-authored-by: Enguerrand LUCAT <enguerrand.lucat@gmail.com>
Co-authored-by: Corentin CHARTIER <corentinchartier334@gmail.com>

# Conflicts:
#	frontend/tests/event.js
@Engu-s @aminssutt
@CocoChart @benel
FIX: Image names may contain special character (fixes #360)
b19f94d 
Co-authored-by: Berache Lakhdar <lakhdarberache@gmail.com>
Co-authored-by: Chartier Corentin <corentinchartier334@gmail.com>
@benel benel merged commit b19f94d into main May 27, 2026
3 checks passed
@benel benel deleted the fix-360 branch May 27, 2026 14:38
@benel
Copy link
Copy Markdown
Member

benel commented May 27, 2026

@CocoChart @Engu-s @aminssutt
Your contribution is live on the production server! Well done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benel benel benel requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CocoChart @benel @aminssutt @Engu-s