Skip to content

add missing to packages#47

Open
Krovatkin wants to merge 1 commit into
Haiyang-W:masterfrom
Krovatkin:master
Open

add missing to packages#47
Krovatkin wants to merge 1 commit into
Haiyang-W:masterfrom
Krovatkin:master

Conversation

@Krovatkin

Copy link
Copy Markdown

This PR adds missing __init__.py to any directory with python files, so setup.py can find all packages and install them correctly.

@Krovatkin

Copy link
Copy Markdown
Author

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

@chenshi3

Copy link
Copy Markdown
Collaborator

@Krovatkin Thanks for your contribution. I will check and merge this PR.

@chenshi3

Copy link
Copy Markdown
Collaborator

@Haiyang-W Thanks for the great work! I've noticed I can't use this package as a 3rd party dependency installed in site-packages due to setup.py not copying all the python files into the package.

The __init__.py under the tools folder is not necessary. You may consider deleting these files.

@Krovatkin Krovatkin force-pushed the master branch 2 times, most recently from f1e4cc3 to 63099c6 Compare July 30, 2023 20:08
@Krovatkin

Krovatkin commented Jul 30, 2023

Copy link
Copy Markdown
Author

I believe if we remove tools/__init__.py, we won't be able to use any one of these as packages either:

tools/__init__.py
tools/eval_utils/__init__.py
tools/process_tools/__init__.py
tools/train_utils/__init__.py
tools/visual_utils/__init__.py

Could you please advise me if this behaviour is what we want?

@Krovatkin

Copy link
Copy Markdown
Author

@chenshi3 ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants