Skip to content

core: fix segmentation fault during global teardown (#3288) #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshal24-chavan wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −8
Open

core: fix segmentation fault during global teardown (#3288) #3331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions srtcore/api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,17 @@ modified by
#include "srt.h"
#include "udt.h"



#define SRT_ENABLE_UNSAFE_LOGS 0

#if SRT_ENABLE_UNSAFE_LOGS
#define HLOGC_UNSAFE HLOGC
#else
#define HLOGC_UNSAFE(...) (void)0
#endif


#ifdef _WIN32
#include <win/wintime.h>
#endif
Expand Down Expand Up @@ -330,8 +341,13 @@ void srt::CUDTUnited::cleanupAllSockets()

void srt::CUDTUnited::closeAllSockets()
{
// IMPORTANT: Do not use standard logging (HLOGC) here.
// This function is called during global program teardown and will cause a
// segmentation fault due to static destruction order.
// Use HLOGC_UNSAFE, which is safely disabled by default.

// remove all sockets and multiplexers
HLOGC(inlog.Debug, log << "GC: GLOBAL EXIT - releasing all pending sockets. Acquiring control lock...");
HLOGC_UNSAFE(inlog.Debug, log << "GC: GLOBAL EXIT - releasing all pending sockets. Acquiring control lock...");

{
// Pre-closing: run over all open sockets and close them.
Expand All @@ -345,9 +361,9 @@ void srt::CUDTUnited::closeAllSockets()
#if ENABLE_BONDING
if (s->m_GroupOf)
{
HLOGC(smlog.Debug,
log << "@" << s->m_SocketID << " IS MEMBER OF $" << s->m_GroupOf->id()
<< " (IPE?) - REMOVING FROM GROUP");
HLOGC_UNSAFE(smlog.Debug,
log << "@" << s->m_SocketID << " IS MEMBER OF $" << s->m_GroupOf->id()
<< " (IPE?) - REMOVING FROM GROUP");
s->removeFromGroup(false);
}
#endif
Expand Down Expand Up @@ -393,7 +409,8 @@ void srt::CUDTUnited::closeAllSockets()
#endif
}

HLOGC(inlog.Debug, log << "GC: GLOBAL EXIT - releasing all CLOSED sockets.");
HLOGC_UNSAFE(inlog.Debug, log << "GC: GLOBAL EXIT - releasing all CLOSED sockets.");

while (true)
{
checkBrokenSockets();
Expand All @@ -405,11 +422,9 @@ void srt::CUDTUnited::closeAllSockets()
if (empty)
break;

HLOGC(inlog.Debug, log << "GC: checkBrokenSockets didn't wipe all sockets, repeating after 1s sleep");
HLOGC_UNSAFE(inlog.Debug, log << "GC: checkBrokenSockets didn't wipe all sockets, repeating after 1s sleep");
srt::sync::this_thread::sleep_for(milliseconds_from(1));
}


}


Expand Down
Loading