core: fix segmentation fault during global teardown (#3288)

[harshal24-chavan]

Removed the HLOGC macros from closeAllSockets() that were causing a segmentation fault during global teardown due to static destruction order. Added a warning comment to prevent future logging in this function.

Fixes #3288

[ethouris]

I had a different solution in mind.

What I need is to have some flag that is 0 by default, but it enables logs in this area. Let's say:

#define SRT_ENABLE_UNSAFE_LOGS 0

#if SRT_ENABLE_UNSAFE_LOGS
#define HLOGC_UNSAFE HLOGC
#else
#define HLOGC_UNSAFE(...) (void)0
#endif

Now, all HLOGC macro uses in this function should be replaced by HLOGC_UNSAFE. In the default configuration this will be simply turned into no instruction. But a developer may need to enable logs in this area temporarily to track any problems, and to do that, they can change SRT_ENABLE_UNSAFE_LOGS locally.

[harshal24-chavan]

okay! yes makes sense, keep it for debugging & exclude them for normal use, thanks for correcting. I'll implement that.

[harshal24-chavan]

Following the pattern I saw in the dev branch with the DONT_HLOGC configuration, I placed the new #define block directly below the #include statements at the top of the file for better discoverability and consistency.

[ethouris]

Yes, that's very good. In perspective also the dev branch will be updated with that solution.