fix(backport): avoid duplicating volatile file projections - #17
Open
discord9 wants to merge 1 commit into
Conversation
Signed-off-by: discord9 <discord9@163.com>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
File-scan projection pushdown can inline a volatile expression at each outer reference site. A volatile expression aliased once in a subquery is then evaluated multiple times instead of once and reused, producing incorrect results such as different values for two references to the same
random()alias.Apache DataFusion fixed this in apache/datafusion@1e77af8. GreptimeDB's pinned fork revision predates that fix.
What changes are included in this PR?
FileScanConfigprojection merging when it would duplicate a volatile inner expression.Are these changes tested?
Yes. Added a focused physical-optimizer regression using a real CSV file scan at one target partition:
Result:
1 passed, 915 filtered out.Temporarily removing the guard makes the regression test fail with different random-value arrays, confirming that the test exercises the affected optimizer path.
cargo fmt --all -- --checkandgit diff --checkalso pass.Are there any user-facing changes?
No API changes. Queries that reuse an aliased volatile expression over a file scan now preserve evaluate-once semantics by retaining the materializing projection.