fix: port GreptimeDB correctness fixes to DataFusion 54 - #20
Closed
discord9 wants to merge 12 commits into
Closed
Conversation
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
10 tasks
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
Author
|
Superseded by #21. The replacement is based directly on official DataFusion 54.1 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — issues are disabled on this fork. This maintenance branch is tracked by GreptimeDB PR #8555.
Rationale for this change
GreptimeDB is upgrading from its DataFusion 53.1 maintenance branch to DataFusion 54. Official
54.0.0already contains most previously tracked fixes, but several correctness fixes either landed after the 54 tag or remain specific to GreptimeDB's query plans.This PR creates a reviewable, test-first thin fork on the exact official
54.0.0commit45d943dfb8699dc9cb9ef2320e955b73e3e6c03b. It carries only fixes with a focused regression and avoids replaying patches already present in 54.What changes are included in this PR?
7303323513467e7ec99fc349e4b388array_resizeby Arrow's maximum array size9297b40fd4adfae34512557ddad236SortPreservingMergeExece2be63976cd385af852dTRY_CASTscalar/array overflow behavior nullablefb7b26d04c027358559bmedian(NULL)and fall back from grouped accumulation0f6dcb128cee35d94cNot replayed:
The resulting thin-fork head is
cee35d94c03300f1b9a21090828826e61cb67b11.Are these changes tested?
Yes. Each semantic port was introduced with a focused regression before its implementation. Final validation includes:
simplify_expr.sltcase;array_resize, volatile projection, timestamp coercion, fetch-aware statistics, global LIMIT/OFFSET, and safeTRY_CASTregressions;datafusion-substraitsuite, including duplicate root names, null-padded joins, deterministic second round trips, and terminal grouping sets: 249 passed, 6 ignored;cargo clippy --workspace --all-targets --all-features -- -D warnings;Are there any user-facing changes?
There is no intentional public API change beyond the DataFusion 54 baseline. The included changes correct query results, optimizer rewrites, statistics, memory accounting, NULL aggregation, Substrait schema reconstruction, and overflow behavior consumed by GreptimeDB.