fix(backport): account for grouped aggregate memory - #16
Open
discord9 wants to merge 1 commit into
Conversation
Backport the grouped AVG and MEDIAN accumulator memory accounting fix from upstream DataFusion commit 73d5d78. Signed-off-by: discord9 <discord9@163.com>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
medianandavgapache/datafusion#23357 (commit73d5d780).Rationale for this change
Grouped AVG and MEDIAN accumulators under-report their owned state on the GreptimeDB DataFusion 53.1 fork. Under constrained query memory, this can delay spill or rejection and allow high-cardinality aggregation to exceed the intended memory budget.
What changes are included in this PR?
No public API or dependency changes are included.
Are these changes tested?
Using the lane sccache configuration:
cargo fmt --all -- --checkgit diff --checkcargo test -p datafusion-functions-aggregate --lib test_groups_accumulator_size_accounts_for_owned_state(2 passed, 0 failed)The pre-fix Greptime harness independently reproduced the accounting gap in two four-attempt runs: AVG reported 512 bytes versus 1072 bytes of owned state, and MEDIAN reported 96 bytes versus 1096 bytes.
Are there any user-facing changes?
Yes. Query memory accounting for grouped AVG and MEDIAN now includes all owned accumulator state, allowing existing memory limits and spill/rejection mechanisms to react at the correct threshold. There are no API changes.