fix(backport): prevent array_resize capacity overflow panic - #15
Open
discord9 wants to merge 1 commit into
Conversation
Signed-off-by: discord9 <discord9@163.com>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
8272b4aa).Rationale for this change
array_resize(make_array(1), 9223372036854775807, 0)panics while creating the physical plan on the GreptimeDB DataFusion 53.1 fork. Oversized resize requests should return a controlled execution error instead of aborting query planning.What changes are included in this PR?
The eager allocation limits cannot prove arbitrary variable-width payload bytes or variable nested-child cardinality copied during
extend; those remain data-dependent. No public API or dependency changes are included.Are these changes tested?
Using the supplied shared target and sccache:
cargo fmt --checkgit diff --checkcargo test -p datafusion-functions-nested --no-fail-fast(57 passed, 1 ignored; 2 doctests passed)cargo test -p datafusion-functions-nested resize::tests::array_resize_huge_size_returns_controlled_error -- --ignored --exact(passed)cargo clippy -p datafusion-functions-nested --all-targets -- -D warningscargo check -p datafusion-functions-nestedThe pre-fix isolated GreptimeDB witness reproduced the panic 4/4 while its small
array_resize([1], 3, 0)control succeeded.Are there any user-facing changes?
Yes. Oversized
array_resizerequests now return an execution error containingexceeds the maximum array sizeinstead of panicking. There are no API changes.