Skip to content

feat: StatusMenu live hero stats and guild name display #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BoroBongo merged 5 commits into from
Jun 16, 2026
Merged

feat: StatusMenu live hero stats and guild name display #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a54b7c8
feat: StatusMenu live hero stats and guild name display
BoroBongo Jun 15, 2026
6ff9300
refactor: remove cheat code from StatusMenu — live stats display only
BoroBongo Jun 15, 2026
128c7a3
Merge branch 'main' into feat/status-menu
BoroBongo Jun 15, 2026
896e8fb
fix: QuestLogMenu arrow and journal text depth in world-space canvas
BoroBongo Jun 15, 2026
f756a4e
max_guild
BoroBongo Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions Assets/Gothic-Core/Scripts/Adapters/UI/Menus/QuestLogMenu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ private void CreateLists()
rect.SetHeight(rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(halfMainWidth - _arrowMargin);
rect.SetPositionY(halfMainHeight - _arrowMargin);
SetLocalZ(rect, -0.03f);
}

// DOWN
Expand All @@ -221,6 +222,7 @@ private void CreateLists()
rect.SetHeight(rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(halfMainWidth - _arrowMargin);
rect.SetPositionY(-halfMainHeight + _arrowMargin);
SetLocalZ(rect, -0.03f);
}
}

Expand All @@ -239,7 +241,7 @@ private void CreateContentViewer()
textComp.overflowMode = TextOverflowModes.Page;
textComp.pageToDisplay = 0;

// UP
// UP - right side, above content
{
var go = _resourceCacheService.TryGetPrefabObject(PrefabType.UiButtonTextured, name: "ARROW_UP", parent: contentViewer.go)!;
var rect = go.GetComponentInChildren<RectTransform>();
Expand All @@ -254,9 +256,10 @@ private void CreateContentViewer()
rect.SetHeight(rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(halfTextWidth + rend.sharedMaterial.mainTexture.width);
rect.SetPositionY(halfTextHeight + rend.sharedMaterial.mainTexture.height);
SetLocalZ(rect, -0.03f);
}

// DOWN
// DOWN - right side, below content
{
var go = _resourceCacheService.TryGetPrefabObject(PrefabType.UiButtonTextured, name: "ARROW_DOWN", parent: contentViewer.go)!;
var rect = go.GetComponentInChildren<RectTransform>();
Expand All @@ -271,9 +274,10 @@ private void CreateContentViewer()
rect.SetHeight(rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(halfTextWidth + rend.sharedMaterial.mainTexture.width);
rect.SetPositionY(-halfTextHeight - rend.sharedMaterial.mainTexture.height);
SetLocalZ(rect, -0.03f);
}

// BACK
// BACK - bottom-left corner, same Y as ARROW_DOWN
{
var go = _resourceCacheService.TryGetPrefabObject(PrefabType.UiButtonTextured, name: "ARROW_BACK", parent: contentViewer.go)!;
var rect = go.GetComponentInChildren<RectTransform>();
Expand All @@ -284,10 +288,12 @@ private void CreateContentViewer()
rend.sharedMaterial = TextureService.ArrowLeftMaterial;
button.onClick.AddListener(OnContentViewerBackClick);

var arrowW = rend.sharedMaterial.mainTexture.width * go.transform.localScale.x;
rect.SetWidth(rend.sharedMaterial.mainTexture.width);
rect.SetHeight(rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(-halfTextWidth - rend.sharedMaterial.mainTexture.width);
rect.SetPositionY(halfTextHeight + rend.sharedMaterial.mainTexture.height);
rect.SetPositionX(-halfTextWidth + arrowW);
rect.SetPositionY(-halfTextHeight - rend.sharedMaterial.mainTexture.height);
SetLocalZ(rect, -0.03f);
}
}

Expand Down Expand Up @@ -399,8 +405,12 @@ private void OnListItemClicked(int index)
Background.SetActive(false);

var contentViewer = MenuItemCache[_instanceContentViewer].go;
contentViewer.GetComponentInChildren<TMP_Text>().text = text;
var tmpText = contentViewer.GetComponentInChildren<TMP_Text>();
tmpText.text = text;
contentViewer.SetActive(true);
tmpText.ForceMeshUpdate(ignoreActiveState: true);
foreach (var subMesh in tmpText.GetComponentsInChildren<TMP_SubMeshUI>())
SetLocalZ(subMesh.rectTransform, -0.02f);
}

private void OnArrowUpClick()
Expand Down Expand Up @@ -464,5 +474,12 @@ protected override void ExecuteCommand(string itemName, string commandName)
// If the Command==ListMenu, then we set it as currently active.
_listMenuCache.TryGetValue(menuItemName, out _activeListMenu);
}

private static void SetLocalZ(RectTransform rect, float z)
{
var pos = rect.localPosition;
pos.z = z;
rect.localPosition = pos;
}
}
}
137 changes: 62 additions & 75 deletions Assets/Gothic-Core/Scripts/Adapters/UI/Menus/StatusMenu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using System;
using System;
using System.Linq;
using Gothic.Core.Model.UI.Menu;
using Gothic.Core.Models.Vm;
using Gothic.Core.Services.Npc;
using Gothic.Core.Services.Vm;
using Gothic.Core.Const;
using MyBox;
using Reflex.Attributes;
using TMPro;
Expand All @@ -18,121 +19,107 @@ public class StatusMenu : AbstractMenu
private string _itemNameLearn = "MENU_ITEM_LEARN";

private string _itemNameAttributePattern = "MENU_ITEM_ATTRIBUTE_{0}";

private string _itemNameArmorPattern = "MENU_ITEM_ARMOR_{0}";

private string _itemTalentTitlePattern = "MENU_ITEM_TALENT_{0}_TITLE";
private string _itemTalentSkillPattern = "MENU_ITEM_TALENT_{0}_SKILL";
private string _itemTalentDescriptionPattern = "MENU_ITEM_TALENT_{0}";


// Attribute slot → (currentIndex, maxIndex); maxIndex -1 means single value
// Gothic engine convention: 1=Strength(4), 2=Dexterity(5), 3=Mana(2/max3), 4=HP(0/max1)
private static readonly int[] _attrCurrentIndex = { 4, 5, 2, 0 };
private static readonly int[] _attrMaxIndex = {-1,-1, 3, 1 };

// Armor slot → DamageType index: 1=Blunt, 2=Point(projectiles), 3=Fire, 4=Magic
// DamageType values: Blunt=1, Point=3, Fire=4, Magic=6
private static readonly int[] _armorProtIndex = { 1, 3, 4, 6 };

[Inject] private readonly VmService _vmService;
[Inject] private readonly NpcService _npcService;


private void Awake()
{
InitializeMenu(new MenuInstanceAdapter("MENU_STATUS", null));
}

public override void InitializeMenu(AbstractMenuInstance menuInstance)
{
base.InitializeMenu(menuInstance);
Setup();
}

private void Setup()
private void OnEnable()
{
if (_npcService == null)
return;
UpdateData();
}

/// <summary>
/// Fill data. Currently demo data.
/// </summary>
private void UpdateData()
{
MenuItemCache[_itemNameGuild].go.GetComponentInChildren<TMP_Text>().text = "TestGuild";
MenuItemCache[_itemNameLevel].go.GetComponentInChildren<TMP_Text>().text = "100";
MenuItemCache[_itemNameExp].go.GetComponentInChildren<TMP_Text>().text = "1337";
MenuItemCache[_itemNameLevelNext].go.GetComponentInChildren<TMP_Text>().text = "13";
MenuItemCache[_itemNameLearn].go.GetComponentInChildren<TMP_Text>().text = "42";
var hero = _npcService.GetHeroContainer();
var vob = hero.Vob;

var guildId = hero.Props.TrueGuild != VmGothicEnums.Guild.GIL_NONE
? (int)hero.Props.TrueGuild
: vob.Guild;

MenuItemCache[_itemNameGuild].go.GetComponentInChildren<TMP_Text>().text = _vmService.GetGuildName(guildId);
MenuItemCache[_itemNameLevel].go.GetComponentInChildren<TMP_Text>().text = vob.Level.ToString();
MenuItemCache[_itemNameExp].go.GetComponentInChildren<TMP_Text>().text = vob.Xp.ToString();
MenuItemCache[_itemNameLevelNext].go.GetComponentInChildren<TMP_Text>().text = vob.XpNextLevel.ToString();
MenuItemCache[_itemNameLearn].go.GetComponentInChildren<TMP_Text>().text = vob.Lp.ToString();

Enumerable.Range(1, 4).ForEach(i =>
Enumerable.Range(0, 4).ForEach(i =>
{
var key = string.Format(_itemNameAttributePattern, i);
MenuItemCache[key].go.GetComponentInChildren<TMP_Text>().text = $"{i}/100";
var key = string.Format(_itemNameAttributePattern, i + 1);
var cur = vob.GetAttribute(_attrCurrentIndex[i]);
var text = _attrMaxIndex[i] >= 0
? $"{cur}/{vob.GetAttribute(_attrMaxIndex[i])}"
: cur.ToString();
MenuItemCache[key].go.GetComponentInChildren<TMP_Text>().text = text;
});

Enumerable.Range(1, 4).ForEach(i =>
Enumerable.Range(0, 4).ForEach(i =>
{
var key = string.Format(_itemNameArmorPattern, i);
MenuItemCache[key].go.GetComponentInChildren<TMP_Text>().text = $"{i}";
var key = string.Format(_itemNameArmorPattern, i + 1);
MenuItemCache[key].go.GetComponentInChildren<TMP_Text>().text = vob.GetProtection(_armorProtIndex[i]).ToString();
});

var talentTitles = _vmService.TalentTitles;
var talentSkills = _vmService.TalentSkills;

Enumerable.Range(0, 12).ForEach(i =>
Enumerable.Range(0, talentTitles.Count).ForEach(i =>
{
var keyTitle = string.Format(_itemTalentTitlePattern, i+1);
var keySkill = string.Format(_itemTalentSkillPattern, i+1);
var keyDescription = string.Format(_itemTalentDescriptionPattern, i+1);
var keyTitle = string.Format(_itemTalentTitlePattern, i + 1);
var keySkill = string.Format(_itemTalentSkillPattern, i + 1);
var keyDescription = string.Format(_itemTalentDescriptionPattern, i + 1);

var randValue = new Random().Next(0, 2);
var skillDescriptionText = talentSkills[i];
if (!MenuItemCache.ContainsKey(keyTitle))
return;

string skillDescriptionFormatted;
if (skillDescriptionText.IsNullOrEmpty() || skillDescriptionText== "|")
var talent = vob.GetTalent(i);
var skillText = talentSkills[i];
string skillFormatted;
if (skillText.IsNullOrEmpty() || skillText == "|")
{
skillDescriptionFormatted = "";
skillFormatted = string.Empty;
}
else
{
skillDescriptionFormatted = skillDescriptionText.Split("|")[randValue];
var parts = skillText.Split("|");
var partIndex = Math.Min(talent.Skill, parts.Length - 1);
skillFormatted = parts[partIndex];
}

MenuItemCache[keyTitle].go.GetComponentInChildren<TMP_Text>().text = talentTitles[i];
MenuItemCache[keySkill].go.GetComponentInChildren<TMP_Text>().text = skillDescriptionFormatted;
MenuItemCache[keySkill].go.GetComponentInChildren<TMP_Text>().text = skillFormatted;

if (MenuItemCache.TryGetValue(keyDescription, out var item))
{
item.go.GetComponentInChildren<TMP_Text>().text = $"{randValue}%";
}
if (MenuItemCache.TryGetValue(keyDescription, out var descItem))
descItem.go.GetComponentInChildren<TMP_Text>().text = $"{talent.Value}%";
});
}

protected override void Undefined(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void StartMenu(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void StartItem(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void Close(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void ConsoleCommand(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void PlaySound(string itemName, string commandName)
{
throw new NotImplementedException();
}

protected override void ExecuteCommand(string itemName, string commandName)
{
throw new NotImplementedException();
}
protected override void Undefined(string itemName, string commandName) { }
protected override void StartMenu(string itemName, string commandName) { }
protected override void StartItem(string itemName, string commandName) { }
protected override void Close(string itemName, string commandName) { }
protected override void ConsoleCommand(string itemName, string commandName) { }
protected override void PlaySound(string itemName, string commandName) { }
protected override void ExecuteCommand(string itemName, string commandName) { }
}
}
9 changes: 9 additions & 0 deletions Assets/Gothic-Core/Scripts/Services/Vm/VmService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ public List<string> TalentSkills
}
}

public string GetGuildName(int guildId)
{
var guilds = _gameStateService.GothicVm.GetSymbolByName("TXT_GUILDS");
var max = _gameStateService.GothicVm.GetSymbolByName("GIL_MAX")?.GetInt(0);
if (guilds == null || guildId < 0 || guildId >= max)
return string.Empty;
return guilds.GetString((ushort)guildId);
}

public int InvCatMax => _gameStateService.GothicVm.GetSymbolByName("INV_CAT_MAX").GetInt(0);
public List<string> InventoryCategories
{
Expand Down