-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 공지 요약 필드 문자열 정규화 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import json | ||
| from types import SimpleNamespace | ||
|
|
||
| from app.services import summarizer | ||
|
|
||
|
|
||
| def test_summarize_notice_normalizes_structured_llm_fields(monkeypatch) -> None: | ||
| payload = { | ||
| "summary": {"핵심": "생활관 소독 안내입니다."}, | ||
| "target_info": {"소독 대상": "전체 생활관"}, | ||
| "schedule_info": {"일시": "2026년 5월 8일 10시"}, | ||
| "caution_info": ["귀중품은 보관해 주세요.", "소독 시간에는 협조 바랍니다."], | ||
| } | ||
|
|
||
| fake_response = SimpleNamespace( | ||
| choices=[ | ||
| SimpleNamespace( | ||
| message=SimpleNamespace(content=json.dumps(payload, ensure_ascii=False)) | ||
| ) | ||
| ], | ||
| model="fake-model", | ||
| ) | ||
| fake_client = SimpleNamespace( | ||
| chat=SimpleNamespace( | ||
| completions=SimpleNamespace(create=lambda **_kwargs: fake_response) | ||
| ) | ||
| ) | ||
| monkeypatch.setattr(summarizer, "client", fake_client) | ||
|
|
||
| result = summarizer.summarize_notice("소독 안내", "생활관 소독을 진행합니다.") | ||
|
|
||
| assert result.summary == "핵심: 생활관 소독 안내입니다." | ||
| assert result.target_info == "소독 대상: 전체 생활관" | ||
| assert result.schedule_info == "일시: 2026년 5월 8일 10시" | ||
| assert result.caution_info == "귀중품은 보관해 주세요.\n소독 시간에는 협조 바랍니다." | ||
| assert result.generated_model == "fake-model" | ||
|
|
||
|
|
||
| def test_to_text_omits_empty_nested_values() -> None: | ||
| assert summarizer._to_text(["A", None, " ", "B"]) == "A\nB" | ||
| assert summarizer._to_text({"대상": "전체", "비고": None, "공백": " "}) == "대상: 전체" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.