Skip to content

Allow attributes to be passed as arguments to custom functions #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwrrp merged 1 commit into from
Jun 30, 2026
Merged

Allow attributes to be passed as arguments to custom functions #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/registerCustomXPathFunction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ export function adaptXPathValueToJavascriptValue(
sequenceType.mult === SequenceMultiplicity.ONE_OR_MORE
) {
return valueSequence.getAllValues().map((value) => {
if (isSubtypeOf(value.type, ValueType.ATTRIBUTE)) {
throw new Error('Cannot pass attribute nodes to custom functions');
}
return transformXPathItemToJavascriptObject(value, executionParameters).next(
IterationHint.NONE,
).value;
Expand Down
13 changes: 6 additions & 7 deletions test/specs/parsing/registerCustomXPathFunction.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,13 +280,12 @@ describe('registerCustomXPathFunction', () => {
);
});

it('disallows attributes as parameters', () => {
chai.assert.throws(

@DrRataplan DrRataplan May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse this test as 'does allow attributes as parameters'?

@egh egh May 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll reverse the logic!

@egh egh May 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and force-pushed changes.

() =>
evaluateXPathToString('test:custom-function3(//@*)', documentNode, null, null, {
namespaceResolver: identityNamespaceResolver,
}),
'Cannot pass attribute nodes',
it('allows attributes as parameters', () => {
chai.assert.equal(
evaluateXPathToString('test:custom-function3(//@*)', documentNode, null, null, {
namespaceResolver: identityNamespaceResolver,
}),
'someValue',
);
});

Expand Down
Loading