Allow attributes to be passed as arguments to custom functions#685
Conversation
BundleMonFiles updated (2)
Total files change -57B -0.03% Final result: ✅ View report in BundleMon website ➡️ |
egh
force-pushed
the
allow-attribute-args-for-functions
branch
from
aac2148 to
c1145e3
Compare
|
coverage: 91.54% (-0.002%) from 91.542% — egh:allow-attribute-args-for-functions into FontoXML:master |
DrRataplan
left a comment
DrRataplan
left a comment
There was a problem hiding this comment.
Coverage dropped marginally because there are fewer branches. Makes sense.
Let's just reuse the older test as a regression test for the future.
Thanks @egh! Must've been a fun puzzle!
| }); | ||
|
|
||
| it('disallows attributes as parameters', () => { | ||
| chai.assert.throws( |
There was a problem hiding this comment.
Can we reuse this test as 'does allow attributes as parameters'?
There was a problem hiding this comment.
Sure, I'll reverse the logic!
There was a problem hiding this comment.
Done and force-pushed changes.
|
I have a vague recollection we had this because something in fontonwas wrong with attributes. Maybe this stems from before we had attribute nodes in blueprints? |
|
@DrRataplan Thanks for the review. I should have added more context. In xjslt I was trying to process a stylesheet which passed attribute nodes as arguments to the |
egh
force-pushed
the
allow-attribute-args-for-functions
branch
from
c1145e3 to
12c848d
Compare
|
@bwrrp do you see a moment to review / merge this PR? |
bwrrp
left a comment
bwrrp
left a comment
There was a problem hiding this comment.
Apologies for the delay, looks good to me! Merging
|
Thank you @bwrrp ! |
4 participants
I'm not sure why this error checking was there: from what I can tell it works fine to pass an attribute into a custom function and the code that is called to transform the xpath value into a javascript value seems to handle attributes: https://github.com/egh/fontoxpath/blob/allow-attribute-args-for-functions/src/transformXPathItemToJavascriptObject.ts#L140