Update daisy to v5#15
Merged
Merged
Conversation
Closed
github-actions
Bot
added
documentation
There was a problem hiding this comment.
Pull request overview
This PR upgrades DaisyUI from v4 to v5 and migrates from Tailwind CSS v3 to v4, introducing significant changes to the styling configuration approach. The migration moves from JavaScript-based configuration files to CSS-based configuration using Tailwind v4's new syntax.
Changes:
- Upgraded Tailwind CSS from v3.4.19 to v4.1.18 and DaisyUI from v4.12.24 to v5.5.14
- Replaced JavaScript configuration (tailwind.config.js, postcss.config.js) with CSS-based configuration in global.css using Tailwind v4 syntax
- Improved type safety by extracting IconName type to a shared types/app.ts file and updating component type annotations
- Refactored resume.astro to use a new ResumeSection component for better code organization
- Updated badge styling from
badgetobadge-soft badge-primaryfor softer visual appearance - Added utility function
concatTextsfor cleaner class name composition - Updated content in resume.json and index.astro to reflect recent professional changes
Reviewed changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependency versions, moved daisyui to devDependencies, removed "start" script |
| astro.config.mjs | Replaced @astrojs/tailwind integration with @tailwindcss/vite plugin |
| tailwind.config.js | Removed (replaced with CSS configuration) |
| postcss.config.js | Removed (replaced with simpler postcss.config.cjs) |
| postcss.config.cjs | New simplified PostCSS configuration |
| src/styles/global.css | Added Tailwind v4 CSS configuration with theme and plugin directives |
| src/types/app.ts | New file defining shared IconName type |
| src/types/resume.ts | Updated to use IconName type, exported Project interface |
| src/utils.ts | New utility function for concatenating class names |
| src/components/Icon.astro | Refactored to import IconName from types/app.ts |
| src/components/ResumeSection.astro | New component for consistent resume section styling |
| src/components/ProjectCard.astro | Updated to use concatTexts utility and improved class organization |
| src/components/HeaderLink.astro | Changed underline-offset from arbitrary value to utility class |
| src/components/ThemeToggle.astro | Improved TypeScript type safety with explicit HTMLElement casts |
| src/components/BaseHead.astro | Added sitemap link |
| src/components/Footer.astro | Minor formatting change in shadow value |
| src/layouts/Default.astro | Added global.css import |
| src/pages/resume.astro | Major refactoring using ResumeSection component, improved layout spacing |
| src/pages/projects.astro | Updated to use Tailwind v4 CSS variable syntax for breakpoints |
| src/pages/index.astro | Updated content to reflect current professional focus |
| src/pages/blog/index.astro | Updated badge styling to use badge-soft |
| tsconfig.json | Added include and exclude configurations |
| resume.json | Updated work experience details and added missing icons |
| pnpm-lock.yaml | Dependency updates reflecting package.json changes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades DaisyUI from v4 to v5 and migrates from Tailwind CSS v3 to v4, introducing significant changes to the styling configuration approach. The migration moves from JavaScript-based configuration files to CSS-based configuration using Tailwind v4's new syntax.
Changes:
Upgraded Tailwind CSS from v3.4.19 to v4.1.18 and DaisyUI from v4.12.24 to v5.5.14
Replaced JavaScript configuration (tailwind.config.js, postcss.config.js) with CSS-based configuration in global.css using Tailwind v4 syntax
Improved type safety by extracting IconName type to a shared types/app.ts file and updating component type annotations
Refactored resume.astro to use a new ResumeSection component for better code organization
Updated badge styling from badge to badge-soft badge-primary for softer visual appearance
Added utility function concatTexts for cleaner class name composition
Updated content in resume.json and index.astro to reflect recent professional changes