Skip to content

fix: re-derive DN status on consolidated-SI billing revert #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayanthns merged 1 commit into from
Jun 26, 2026
Merged

fix: re-derive DN status on consolidated-SI billing revert #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rmax_custom/api/delivery_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,11 @@ def unmark_consolidated_dns_billed(si_name):
):
try:
dn = frappe.get_doc("Delivery Note", dn_name)
# update_billing_status recomputes per_billed (→ 0 for a pure net-off
# DN) but does NOT re-derive the status field; set_status must run
# after it or the DN stays stuck on "Completed".
dn.update_billing_status(update_modified=False)
dn.set_status(update=True, update_modified=False)
except Exception:
frappe.db.set_value(
"Delivery Note", dn_name,
Expand Down
Loading