fix: re-derive DN status on consolidated-SI billing revert#26
Merged
Conversation
unmark_consolidated_dns_billed called update_billing_status (recomputes per_billed) but not set_status, so a clubbed DN stayed "Completed" after the consolidated SI was cancelled/deleted instead of reverting to "To Bill". Add dn.set_status(update=True) after the recompute. Caught by the UAT regression test test_clubbed_dn_billing_status_flips_on_submit_and_reverts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25.
unmark_consolidated_dns_billedrecomputedper_billedbut notstatus, so a clubbed DN stayed Completed after the SI was cancelled/deleted. Addset_status(update=True). Caught by the UAT regression test.