Skip to content

Use a full-page country selector#123

Merged
OziinG merged 1 commit into
devfrom
cc-145-full-page-country-selector
Jul 15, 2026
Merged

Use a full-page country selector#123
OziinG merged 1 commit into
devfrom
cc-145-full-page-country-selector

Conversation

@OziinG

@OziinG OziinG commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

CLEVER PR review completion

변경 내용

  • Replaced the phone form inline country overlay with a dedicated full-page selector.
  • Kept search visible but unfocused so scrolling is the default interaction.
  • Reused existing localized country search, selection, and national phone reformatting behavior.
  • Added full-page back behavior and excluded the selector from bottom navigation.

PR Scope Grouping Gate

  • grouping decision: single-pr
  • same document/operating-rule cleanup: one driver login country-selection UX slice
  • same validation command: driver app workspace checks and bundle build
  • different app/service/contract surface: none
  • merge order dependency: none
  • rollback unit: the country-selection screen change

검증

  • npm run check:workspace — passed, 241/241 tests
  • npm run lint — passed
  • npm run build — passed for Android and iOS exports
  • git diff --check — passed
  • Android preview — full page opened with a scrollable list and keyboard hidden on entry
  • User physical-device confirmation — passed
  • Physical iOS interaction — not tested

Concurrent Work Gate

PR 검토 에이전트 종료 조건

  • This change does not alter service responsibility, API, data flow, public contract, runtime environment, permissions, or deploy configuration.

Context/wiki completion

  • repo docs checked: docs/project-brief.md and current app source/test contracts
  • context docs checked: no service-context read was required for this UI-only change
  • wiki/service context update result: not-needed
  • service doc update: none
  • wiki update: none
  • clever-context-monorepo update: none
  • not-needed reason: presentation and navigation state only; existing phone normalization and authentication contracts are unchanged

Linked issue close evidence

Move the long country list out of the phone form while retaining the existing search, locale, and phone formatting boundaries.

Constraint: Search stays visible but passive until the driver taps it.

Rejected: Add a picker or navigation dependency | Existing AppScreen and ScrollView behavior cover the requirement.

Confidence: high

Scope-risk: narrow

Directive: Keep country selection independent from phone authentication API behavior.

Tested: npm run check:workspace; npm run lint; npm run build; git diff --check; Android preview; user confirmation

Not-tested: Physical iOS interaction
@OziinG OziinG linked an issue Jul 15, 2026 that may be closed by this pull request
4 tasks
@OziinG
OziinG merged commit 39b7c93 into dev Jul 15, 2026
1 check passed
@OziinG
OziinG deleted the cc-145-full-page-country-selector branch July 15, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace inline country selector with a full-page searchable list

1 participant