Skip to content

PR 10: Move dashboard to sample read APIs#129

Closed
cm2435 wants to merge 7 commits into
codex/episode-sample-pr09-cli-inspectionfrom
codex/episode-sample-pr10-dashboard
Closed

PR 10: Move dashboard to sample read APIs#129
cm2435 wants to merge 7 commits into
codex/episode-sample-pr09-cli-inspectionfrom
codex/episode-sample-pr10-dashboard

Conversation

@cm2435

@cm2435 cm2435 commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Guide

Stack position: PR 10, base codex/episode-sample-pr09-cli-inspection, head codex/episode-sample-pr10-dashboard.

Implements RFC Docs

  • 03-core-runtime-persistence-fe.md: dashboard reads experiment/environment/sample/sampler state.
  • 03b-implementation-churn.md: FE moves from definition/run pages to experiment/sample pages.
  • 09-implementation-plan/11-pr-10-dashboard.md, partially.
  • Part of 09-implementation-plan/14-remediation-plan.md: dashboard contract/type cleanup.

Why This PR Exists

This moves the dashboard onto the sample-centered read APIs introduced in PR 08, so experiment pages and sample pages render experiment, environment, sampler, sample, event, and graph state rather than definition/run analytics.

What Actually Changes

  • Replaces /experiments/[definitionId] with /experiments/[experimentId].
  • Adds sample-centered dashboard components:
    • ExperimentDetail.tsx
    • SampleTable.tsx
    • SampleDetail.tsx
    • SampleEvents.tsx
  • Adds state builders in src/lib/sample-state/dashboard.ts.
  • Adds server loaders for experiments and samples under src/lib/server-data.
  • Uses backend routes such as /experiments/{id}, /samples/{id}, /samples/{id}/events, and /samples/{id}/graph.
  • Updates dashboard contract/unit/component tests.

Gotchas / Review Risks

  • This PR does not itself regenerate the REST/event files. It wraps existing/generated schemas in handwritten contract bridges such as ExperimentDetailSchema and SampleEventViewSchema.
  • Some legacy bridge names remain: RawExperimentRunRow, ExperimentRunMetrics, parseExperimentDetail, loadSampleSnapshot, and harness fields like runs/mutationsBySample.
  • Links currently route to /samples/{id}/detail with a redirect, even though the plan wants /samples/{id} as the canonical path.
  • SampleEvents.tsx renders generic event type/target fields rather than exhaustively using the discriminated event union.
  • Do not read this as complete dashboard vocabulary cleanup; it is the consumer migration layer.

Cleaned Later

  • Later remediation should delete /detail, regenerate contracts cleanly, rename harness/socket/activity leftovers, and collapse REST/live event compatibility types.
  • PR 11 removes definition launch surfaces that the dashboard no longer depends on.

Validation Notes

Agent review saw Python lint/type, frontend lint/type, unit/state, and integration passing for this PR; dashboard e2e/smokes were still failing. Review should focus on whether the remaining compatibility bridge names are temporary and tracked.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr09-cli-inspection branch from cb0d9a0 to 7c5d180 Compare May 26, 2026 23:18
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 22ce6b5 to 937aa75 Compare May 26, 2026 23:21
@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

Screenshots pushed to screenshots/pr-129.

researchrubrics/26cd5f7f-5ae3-438e-88d6-8ff08320d23a-activity-stack.png
researchrubrics/26cd5f7f-5ae3-438e-88d6-8ff08320d23a-happy.png
researchrubrics/26cd5f7f-5ae3-438e-88d6-8ff08320d23a-visual-debugger-full.png
researchrubrics/bc4d321e-370c-4b0b-8093-653dad7209d5-activity-stack.png
researchrubrics/bc4d321e-370c-4b0b-8093-653dad7209d5-sad.png
researchrubrics/bc4d321e-370c-4b0b-8093-653dad7209d5-visual-debugger-full.png
researchrubrics/d53ce0a4-abb5-43ae-95a3-ef520d51afc0-activity-stack.png
researchrubrics/d53ce0a4-abb5-43ae-95a3-ef520d51afc0-happy.png
researchrubrics/d53ce0a4-abb5-43ae-95a3-ef520d51afc0-visual-debugger-full.png

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

Screenshots pushed to screenshots/pr-129.

swebench-verified/4952b4b2-dbea-4d80-84b3-0af318d2afbd-activity-stack.png
swebench-verified/4952b4b2-dbea-4d80-84b3-0af318d2afbd-happy.png
swebench-verified/4952b4b2-dbea-4d80-84b3-0af318d2afbd-visual-debugger-full.png
swebench-verified/636f6066-82ab-4838-b473-4741faf1f472-activity-stack.png
swebench-verified/636f6066-82ab-4838-b473-4741faf1f472-happy.png
swebench-verified/636f6066-82ab-4838-b473-4741faf1f472-visual-debugger-full.png
swebench-verified/659ca6e0-b34b-45df-984c-745ab9c4d870-activity-stack.png
swebench-verified/659ca6e0-b34b-45df-984c-745ab9c4d870-sad.png
swebench-verified/659ca6e0-b34b-45df-984c-745ab9c4d870-visual-debugger-full.png

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

Screenshots pushed to screenshots/pr-129.

minif2f/2adc66d7-7e75-4d29-8159-e359700fa91b-activity-stack.png
minif2f/2adc66d7-7e75-4d29-8159-e359700fa91b-sad.png
minif2f/2adc66d7-7e75-4d29-8159-e359700fa91b-visual-debugger-full.png
minif2f/318fe59d-7b55-4785-be3f-ecfe62bff62d-activity-stack.png
minif2f/318fe59d-7b55-4785-be3f-ecfe62bff62d-happy.png
minif2f/318fe59d-7b55-4785-be3f-ecfe62bff62d-visual-debugger-full.png
minif2f/ed3f1a06-8564-49d4-b968-8cba5c7c3259-activity-stack.png
minif2f/ed3f1a06-8564-49d4-b968-8cba5c7c3259-happy.png
minif2f/ed3f1a06-8564-49d4-b968-8cba5c7c3259-visual-debugger-full.png

@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch 2 times, most recently from 401a7f8 to b876471 Compare May 27, 2026 14:00
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 2abc1f4 to 5928d70 Compare May 27, 2026 14:19
@cm2435
cm2435 force-pushed the codex/episode-sample-pr09-cli-inspection branch from 492df28 to 1eb807b Compare May 27, 2026 14:19
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

1 similar comment
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr09-cli-inspection branch from 1eb807b to 45490c2 Compare May 27, 2026 14:24
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 5928d70 to 192e6f7 Compare May 27, 2026 14:24
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

1 similar comment
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr09-cli-inspection branch from 45490c2 to a2a8ddf Compare May 27, 2026 14:44
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 192e6f7 to 75d44f8 Compare May 27, 2026 14:44
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-129 for the uploaded placeholder.

@cm2435 cm2435 mentioned this pull request May 27, 2026
Closed
@cm2435

cm2435 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Closed after landing the cumulative episode/sample stack snapshot through PR132 directly onto dev in merge commit 1c22130. This PR's changes are included in dev.

@cm2435 cm2435 closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cm2435