Skip to content

PR 11: Remove public definition launch surfaces - #130

Closed
cm2435 wants to merge 1 commit into
codex/episode-sample-pr10-dashboardfrom
codex/episode-sample-pr11-delete-definition-runtime
Closed

PR 11: Remove public definition launch surfaces#130
cm2435 wants to merge 1 commit into
codex/episode-sample-pr10-dashboardfrom
codex/episode-sample-pr11-delete-definition-runtime

Conversation

@cm2435

@cm2435 cm2435 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Review Guide

Stack position: PR 11, base codex/episode-sample-pr10-dashboard, head codex/episode-sample-pr11-delete-definition-runtime.

Implements RFC Docs

  • Part of 09-implementation-plan/12-pr-11-delete-definition-runtime-path.md: public launch/API cleanup.
  • Part of 09-implementation-plan/14-remediation-plan.md: definition launch surface cleanup.

Why This PR Exists

This PR removes the most visible public definition launch surfaces from the API, CLI-facing tests, routes, and docs. It is an important cleanup step, but the actual diff is narrower than the full destructive-migration section of the planning doc.

What Actually Changes

  • Removes persist_benchmark from the root ergon_core.api export.
  • Deletes POST /experiments/{definition_id}/run from core/infrastructure/http/routes/experiments.py.
  • Updates sample CLI tests away from direct definition-backed SQLModel fixtures toward read-service fakes.
  • Adds/updates route guards proving the removed definition-run route is unavailable.
  • Updates the benchmark README to stop advertising persist_benchmark / definition-run flows.

Gotchas / Review Risks

  • This PR should not be reviewed as the full destructive definition-runtime deletion unless the branch is updated. The diff reviewed by the subagent did not delete persistence/definitions, definition_writer.py, launch.py, definition columns, or the associated destructive migration.
  • Definition persistence/runtime internals still remain in the stack at this point.
  • The planning doc title overstates the current patch. Review the actual files changed, not just the PR name.
  • At agent review time, dashboard e2e and three smokes were failing while Python unit/state, integration, lint/type, and frontend lint/type were passing.

Cleaned Later

  • Full deletion of definition tables, bridge columns, definition writer/launch services, and old runtime tests must happen in a later cleanup/remediation patch if it is not added to this PR.
  • PR 12 builds on the sample/experiment path for trainer rollouts.

Validation Notes

Focus validation on public API exports, removed REST route behavior, CLI/parser expectations, and documentation changes. Do not assume this PR has completed every destructive migration item from the RFC.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 22ce6b5 to 937aa75 Compare May 26, 2026 23:21
@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from 8ff02fd to 0866dd6 Compare May 26, 2026 23:22
@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from 0866dd6 to 16696c3 Compare May 26, 2026 23:34
@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

Screenshots pushed to screenshots/pr-130.

swebench-verified/20ebe82a-8d5f-415f-8f34-8b28b8afcd4f-activity-stack.png
swebench-verified/20ebe82a-8d5f-415f-8f34-8b28b8afcd4f-happy.png
swebench-verified/20ebe82a-8d5f-415f-8f34-8b28b8afcd4f-visual-debugger-full.png
swebench-verified/7a8a685c-1269-4586-bbe9-f93038a73a3a-activity-stack.png
swebench-verified/7a8a685c-1269-4586-bbe9-f93038a73a3a-happy.png
swebench-verified/7a8a685c-1269-4586-bbe9-f93038a73a3a-visual-debugger-full.png
swebench-verified/ec473f6c-2333-4723-8eaa-136fb893794b-activity-stack.png
swebench-verified/ec473f6c-2333-4723-8eaa-136fb893794b-sad.png
swebench-verified/ec473f6c-2333-4723-8eaa-136fb893794b-visual-debugger-full.png

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

Screenshots pushed to screenshots/pr-130.

minif2f/291c14a9-8b73-46a9-8275-683114c00e56-activity-stack.png
minif2f/291c14a9-8b73-46a9-8275-683114c00e56-happy.png
minif2f/291c14a9-8b73-46a9-8275-683114c00e56-visual-debugger-full.png
minif2f/c89bd4fb-61aa-4532-ab60-9d6fff1aaf05-activity-stack.png
minif2f/c89bd4fb-61aa-4532-ab60-9d6fff1aaf05-happy.png
minif2f/c89bd4fb-61aa-4532-ab60-9d6fff1aaf05-visual-debugger-full.png
minif2f/d83abbfd-1a9a-477c-8e4a-bca40e593019-activity-stack.png
minif2f/d83abbfd-1a9a-477c-8e4a-bca40e593019-sad.png
minif2f/d83abbfd-1a9a-477c-8e4a-bca40e593019-visual-debugger-full.png

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

Screenshots pushed to screenshots/pr-130.

researchrubrics/0ca8a1dc-f660-4704-aabb-a7cc70ad7965-activity-stack.png
researchrubrics/0ca8a1dc-f660-4704-aabb-a7cc70ad7965-sad.png
researchrubrics/0ca8a1dc-f660-4704-aabb-a7cc70ad7965-visual-debugger-full.png
researchrubrics/335debcb-aa81-4834-b539-bbe766425c76-activity-stack.png
researchrubrics/335debcb-aa81-4834-b539-bbe766425c76-happy.png
researchrubrics/335debcb-aa81-4834-b539-bbe766425c76-visual-debugger-full.png
researchrubrics/cb170bfd-36b8-4787-976f-8c3fc0f9bc29-activity-stack.png
researchrubrics/cb170bfd-36b8-4787-976f-8c3fc0f9bc29-happy.png
researchrubrics/cb170bfd-36b8-4787-976f-8c3fc0f9bc29-visual-debugger-full.png

@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from eb6622f to 401a7f8 Compare May 27, 2026 13:53
@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from 16696c3 to 17563ab Compare May 27, 2026 13:53
@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

1 similar comment
@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

1 similar comment
@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from 17563ab to f9c1062 Compare May 27, 2026 14:00
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 401a7f8 to b876471 Compare May 27, 2026 14:00
@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from f9c1062 to c7a57e0 Compare May 27, 2026 14:07
@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from c7a57e0 to 5a3941b Compare May 27, 2026 14:19
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 2abc1f4 to 5928d70 Compare May 27, 2026 14:19
@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

1 similar comment
@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from 5a3941b to c32250d Compare May 27, 2026 14:24
@cm2435
cm2435 force-pushed the codex/episode-sample-pr10-dashboard branch from 5928d70 to 192e6f7 Compare May 27, 2026 14:24
@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from c32250d to b8675b8 Compare May 27, 2026 14:44
@cm2435
cm2435 force-pushed the codex/episode-sample-pr11-delete-definition-runtime branch from b8675b8 to cb76096 Compare May 27, 2026 14:48
@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — researchrubrics

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — swebench-verified

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@github-actions

Copy link
Copy Markdown

E2E smoke — minif2f

No PNG screenshots were uploaded for this leg. See screenshots/pr-130 for the uploaded placeholder.

@cm2435

cm2435 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Closed after landing the cumulative episode/sample stack snapshot through PR132 directly onto dev in merge commit 1c22130. This PR's changes are included in dev.

@cm2435 cm2435 closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant