You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Part of 09-implementation-plan/14-remediation-plan.md: CLI concept-fragment cleanup.
Why This PR Exists
The CLI should inspect experiments and samples through read models. It should not become a second job-submission API. This PR adds read-only experiment/sample inspection commands and removes old mutating/runtime commands from this surface.
What Actually Changes
Adds experiment CLI domain files under ergon_cli/domains/experiments:
experiment list
experiment show
experiment samples
experiment sampler-invocations
Adds sample CLI domain files under ergon_cli/domains/samples:
sample show
sample events
sample graph
Removes legacy/mutating CLI surfaces including sample cancel, sample list --definition-id, experiment tags, and experiment by-tag.
Adds guards/tests for no generic experiment submit command and CLI state rendering.
Updates experiment/sample CLI tests to use read-model fakes.
Gotchas / Review Risks
The examples CLI path is not materially changed here; this is inspection-focused.
CLI services import core read services directly. That may be acceptable for now, but the remediation plan calls out a cleaner HTTP/read-client seam later.
ergon benchmark public naming is not addressed in this PR.
The definition identity naming guard is adjusted so legitimate experiment_id fields do not fail it.
Future cleanup should tighten CLI boundary shape and benchmark naming.
Validation Notes
Key tests are test_no_generic_experiment_submit.py, test_cli_state_rendering.py, test_experiment_cli.py, and test_sample_cli.py. Agent review saw Python lint/type, unit/state, and integration passing, with frontend/smoke failures elsewhere in the stack.
Closed after landing the cumulative episode/sample stack snapshot through PR132 directly onto dev in merge commit 1c22130. This PR's changes are included in dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Guide
Stack position: PR 09, base
codex/episode-sample-pr08-read-apis, headcodex/episode-sample-pr09-cli-inspection.Implements RFC Docs
04-ecosystem/01-cli.md: CLI inspection, not CLI submission.04-cli-builtins-examples-ecosystem.md: ecosystem entrypoint changes.09-implementation-plan/10-pr-09-cli-inspection.md.09-implementation-plan/14-remediation-plan.md: CLI concept-fragment cleanup.Why This PR Exists
The CLI should inspect experiments and samples through read models. It should not become a second job-submission API. This PR adds read-only experiment/sample inspection commands and removes old mutating/runtime commands from this surface.
What Actually Changes
ergon_cli/domains/experiments:experiment listexperiment showexperiment samplesexperiment sampler-invocationsergon_cli/domains/samples:sample showsample eventssample graphsample cancel,sample list --definition-id,experiment tags, andexperiment by-tag.Gotchas / Review Risks
ergon benchmarkpublic naming is not addressed in this PR.experiment_idfields do not fail it.Cleaned Later
Validation Notes
Key tests are
test_no_generic_experiment_submit.py,test_cli_state_rendering.py,test_experiment_cli.py, andtest_sample_cli.py. Agent review saw Python lint/type, unit/state, and integration passing, with frontend/smoke failures elsewhere in the stack.