-
Notifications
You must be signed in to change notification settings - Fork 3
Add type hints on functions definition and Replace the print with logger #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devHanif-git
wants to merge
4
commits into
Davi-S:QT
Choose a base branch
from
devHanif-git:Toolorant-Fetch-From-API
base: QT
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fdf8c07
add dynamically get AGENTS and MAP DATA from API
devHanif-git ed8228c
Add type hints on functions definition and Replace the print with logger
devHanif-git 803e857
Add type hints on functions definition and Replace the print with logger
devHanif-git ec9507a
Merge branch 'QT' into Toolorant-Fetch-From-API
devHanif-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| import enum | ||
| import requests | ||
| import logging | ||
| from typing import Callable, Dict, List, Tuple | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| def fetch_dynamic_enum(enum_name, url, process_items): | ||
| def fetch_dynamic_enum(enum_name: str, url: str, process_items: Callable[[List[Dict]], List[Tuple[str, str]]]) -> enum.Enum: | ||
| """Fetch data from API and create an Enum dynamically with deduplication""" | ||
| try: | ||
| logger.info(f"Fetching {enum_name} data from {url}") | ||
|
|
@@ -19,7 +20,7 @@ def fetch_dynamic_enum(enum_name, url, process_items): | |
| if name not in unique_items: | ||
| unique_items[name] = value | ||
| else: | ||
| print(f"Warning: Duplicate map name detected and skipped - {name}") | ||
| logger.warning(f"Duplicate map name detected and skipped: {name}") | ||
|
|
||
| logger.info("Processed %s items: %s", enum_name, ', '.join(f"{k}: {v}" for k, v in unique_items.items())) | ||
|
|
||
|
|
@@ -28,7 +29,7 @@ def fetch_dynamic_enum(enum_name, url, process_items): | |
| logger.error(f"Failed to fetch {enum_name}: {e}") | ||
| raise RuntimeError(f"Failed to fetch {enum_name}: {e}") | ||
|
|
||
| def process_agents(agents_data): | ||
| def process_agents(agents_data: List[Dict]) -> List[Tuple[str, str]]: | ||
| logger.info("Processing agents data") | ||
| agents = [ | ||
| a for a in agents_data | ||
|
|
@@ -41,7 +42,7 @@ def process_agents(agents_data): | |
| for a in sorted_agents | ||
| ] | ||
|
|
||
| def process_maps(maps_data): | ||
| def process_maps(maps_data: List[Dict]) : | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you accidentally deleted the return type hint |
||
| logger.info("Processing maps data") | ||
| map_items = [] | ||
| for m in maps_data: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
import typing as tandt.Callable,t.Dict...