Add type hints on functions definition and Replace the print with logger#16
Open
devHanif-git wants to merge 4 commits into
Open
Add type hints on functions definition and Replace the print with logger#16devHanif-git wants to merge 4 commits into
devHanif-git wants to merge 4 commits into
Conversation
Davi-S
requested changes
Feb 15, 2025
| ] | ||
|
|
||
| def process_maps(maps_data): | ||
| def process_maps(maps_data: List[Dict]) : |
Owner
There was a problem hiding this comment.
I think you accidentally deleted the return type hint
| import enum | ||
| import requests | ||
| import logging | ||
| from typing import Callable, Dict, List, Tuple |
Owner
There was a problem hiding this comment.
use import typing as t and t.Callable, t.Dict...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.