feat: pin library defaults for v2#19
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e84c5e9e14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
More details
All adversarial scenarios passed clean. The seven library defaults in src/commands/autoinstrument.yml now supply non-empty DD_SET_TRACER_VERSION_* env vars to the install script instead of empty strings, which is the correct handoff the install script already expected. The three new maintenance scripts have valid semver comparison logic, correct YAML/README regex patterns, robust duplicate detection, and proper label-precedence ordering.
📊 Validated against 14 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 167fe35 · What is Autotest? · Any feedback? Reach out in #autotest
What does this PR do?
Prepares v2 by replacing runtime
latestresolution with reviewed default versions for every supported library:3.49.01.64.06.3.04.11.07.15.11.34.0v1.11.0It also documents orb-version and per-library pinning trade-offs, adds the v1-to-v2 migration guide, and adds local helpers for batched library bumps and label-driven orb releases.
Motivation
Resolving the latest library versions during customer runs can change their environment without a new orb release. Pinned defaults make orb releases reproducible while preserving explicit per-library overrides.
This adapts the corresponding GitHub Action implementation from DataDog/test-visibility-github-action#70 to CircleCI registry-orb semantics.
Additional Notes
The current latest tag is
v1.2.7. Thesemver-majorlabel makesscripts/release-orb.shselectv2.0.0after this PR is merged. The helper creates only an immutablevX.Y.Ztag; CircleCI resolves@2through the orb registry, so nov2Git branch is created or moved.No orb version or Git tag is published by this PR. The pinned installation-script URL and checksum are unchanged, and transitive dependency pinning remains owned by the individual libraries.
Possible Drawbacks / Trade-offs
Customers moving from
@1to@2may receive different libraries on their first v2 run.@2receives reviewed compatible v2 releases and library bumps, while@2.0.0remains fixed. An explicit library-version parameter stays authoritative across orb updates but must be updated manually for future library fixes.Describe how to test/QA your changes
bash -non all three new scripts.src/commands/autoinstrument.yml.--dry-run; all pins are current.semver-majorrelease afterv1.2.7; it selectedv2.0.0without changing refs.--tagand--shadry-run paths.