release: verify commits through GitHub#20
Merged
juan-fernandez merged 1 commit intoJul 16, 2026
Conversation
daniel-mohedano
approved these changes
Jul 16, 2026
There was a problem hiding this comment.
More details
The PR correctly replaces local GPG keyring verification with GitHub's API-based verification for release commits. The implementation properly handles all response cases (verified true/false/null), correctly rejects non-verified commits, and fails safely when the GitHub API is unavailable. No behavioral regressions detected — core security semantics remain unchanged while eliminating machine-specific GPG setup.
📊 Validated against 12 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit c392ea0 · What is Autotest? · Any feedback? Reach out in #autotest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Verifies the release commit using GitHub's commit verification API instead of the maintainer's local GPG keyring.
Motivation
The squash merge commit from #19 is signed by GitHub and reported as verified on GitHub, but
git verify-commitfails when the maintainer's local GPG keyring does not contain GitHub'sweb-flowpublic key. This blockedscripts/release-orb.sh --dry-runbefore the planned v2 release.This matches the release verification approach introduced in DataDog/test-visibility-github-action#70.
Additional Notes
The release helper already requires an authenticated
ghsession for PR label discovery, so this does not introduce another tool or authentication requirement.Possible Drawbacks / Trade-offs
Signature validation now trusts GitHub's verification result and requires the GitHub API to be available. This avoids machine-specific GPG keyring setup and is consistent with the equivalent GitHub Action release helper.
Describe how to test/QA your changes
The dry run completes successfully and proposes
v2.0.0from PR #19 without creating or pushing a tag.