enhancement(antithesis): Vary datadog.yaml in test/antithesis, assert aliveness#1779
Draft
blt wants to merge 1 commit into
Draft
Conversation
dd-octo-sts
Bot
added
area/components
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 31, 2026
|
blt
force-pushed
the
blt/assert_adp_aliveness_on_bootup_add_sometimes_check_to_forwarding
branch
from
a372743 to
dc9a86b
Compare
blt
changed the title
Binary Size Analysis (Agent Data Plane)Baseline: 1bd1613 · Comparison: a152801 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This PR introduces variation in the datadog.yaml we use under test in the antithesis rig. The goal here is to explore variation in buffer sizes etc and also startup panics on truly weird configs. ADP aliveness on bootup via the way it is rigged into the compose cluster and we assert a 'sometimes' check to forwarding in datadog/io.rs. This later 'sometimes' acts as a checkpoint for antithesis, allowing it to figure that ADP has reached a nominally functional state and can be explored from that point. The antithesis setup checkpoint is done before datadog.yaml is sampled. Notable things: * first_sample_config runs after setup-checkpoint and before ADP boots, is responsible for creating datadog.yaml and other configs in the future * eventually_adp_alive is a weak check and we may drop it in the future as our coverage improves, but it doesn't hurt anything now * I introduced a harness::rand to encode antithesis-friendly sampling of large domains, this will expand over time * Skill `antithesis-research` has updated its 'scratchbook' but this is a mechanical domain for now, will later convert it to a human-hybrid material
blt
force-pushed
the
blt/assert_adp_aliveness_on_bootup_add_sometimes_check_to_forwarding
branch
from
dc9a86b to
a152801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces variation in the datadog.yaml we use under test in
the antithesis rig. The goal here is to explore variation in buffer
sizes etc and also startup panics on truly weird configs.
ADP aliveness on bootup via the way it is rigged into the compose cluster and we assert a 'sometimes' check to forwarding in datadog/io.rs. This later 'sometimes' acts as a checkpoint for antithesis, allowing it to figure that ADP has reached a nominally functional state and can be explored from that point. The antithesis setup checkpoint is done before datadog.yaml is sampled.
Notable things:
antithesis-researchhas updated its 'scratchbook' but this is a mechanical domain for now, will later convert it to a human-hybrid materialChange Type
How did you test this PR?
Antithesis shots with change in place, confirmed config == timeline match.
References
N/A