docs(agent-data-plane): Antithesis research scratchbook and bug ledger#1768
docs(agent-data-plane): Antithesis research scratchbook and bug ledger#1768blt wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Binary Size Analysis (Agent Data Plane)Baseline: 1bd1613 · Comparison: 3952ec9 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
c269079 to
e840a73
Compare
6b01012 to
c9699d1
Compare
e840a73 to
8712b69
Compare
25934ae to
330a22f
Compare
8712b69 to
3265657
Compare
330a22f to
f8bab09
Compare
3265657 to
af46baf
Compare
f8bab09 to
d048536
Compare
af46baf to
5cb8545
Compare
d048536 to
e4defed
Compare
d604067 to
a649f24
Compare
e4defed to
9994924
Compare
a649f24 to
249a646
Compare
e46f656 to
fb9e655
Compare
249a646 to
05efef3
Compare
fb9e655 to
4d533a8
Compare
05efef3 to
08ac10a
Compare
4d533a8 to
ac323be
Compare
267fc94 to
982687b
Compare
ac323be to
6b922f8
Compare
982687b to
fc4bb29
Compare
6b922f8 to
476a5b6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc4bb29728
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| | # | Property | Test | Defect | | ||
| |---|----------|------|--------| | ||
| | 1 | `aggregate-no-panic-any-window` | `lib/saluki-components/.../transforms/aggregate/mod.rs::tests::bug_sub_second_aggregate_window_panics_on_insert` | Sub-second `aggregate_window_duration` → `bucket_width_secs=0` → `align_to_bucket_start` does `% 0` → panic on first insert (crash + restart loop). | |
There was a problem hiding this comment.
Remove stale aggregate panic repro
This ledger is being added on top of parent 476a5b6, where AggregateConfiguration already deserializes aggregate_window_duration_seconds as NonZeroU64 and align_to_bucket_start takes a NonZeroU64, so a zero bucket width cannot reach the modulo path; zero or fractional-second values fail configuration parsing instead. Keeping this as a current failing repro sends the Antithesis bug work toward an already-fixed/non-reproducible defect and also invalidates the “expect six FAILURES” command below.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Adds Antithesis research documentation for the agent-data-plane DogStatsD scope under test/antithesis/scratchbook/, including property evidence, evaluation synthesis, and a bug ledger.
Changes:
- Adds per-property evidence files for memory, aggregation, config, lifecycle, retry, replay, parsing, and event/service-check behavior.
- Adds portfolio-level relationship and synthesis documents.
- Adds a bug ledger mapping discovered defects to repro vehicles or follow-up Antithesis shots.
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test/antithesis/scratchbook/property-relationships.md |
Groups properties into shared mechanism clusters. |
test/antithesis/scratchbook/existing-assertions.md |
Documents absence of Antithesis SDK assertions. |
test/antithesis/scratchbook/evaluation/synthesis.md |
Summarizes evaluation lenses, added gaps, refinements, and scope decisions. |
test/antithesis/scratchbook/bug-ledger.md |
Tracks discovered defects and repro/triage status. |
test/antithesis/scratchbook/properties/*.md |
Adds detailed evidence and proposed assertions for individual properties across ADP behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Lightweight clustering of the 26 catalog properties by shared code paths, failure mechanisms, and | ||
| suspected dominance. Slugs match `property-catalog.md`. |
| config only as a crash gate — never as a data-correctness event, despite the watcher hazards | ||
| (`broadcast::Lagged` silent drop → stale filtering; partial-deserialize half-apply; key-deletion | ||
| silently clears all tag filtering, `watcher.rs:43-67`) and the design partner's documented "Tag |
| slug: ddsketch-relative-error-bound | ||
| title: DDSketch quantiles within relative-error bound; merges associative/commutative | ||
| type: Safety | ||
| priority: Medium |
| slug: ddsketch-bin-count-bounded | ||
| title: DDSketch bin count never exceeds bin_limit | ||
| type: Safety | ||
| priority: High |
| title: High-severity incompatible config refuses to start the pipeline | ||
| family: Lifecycle Transitions & Configuration | ||
| type: Safety (Reachability / Unreachable) | ||
| priority: High |
## Summary The Antithesis research artifacts for agent-data-plane, under `test/antithesis/scratchbook/`. This is the analysis behind the harness and the bug repros: - A SUT analysis of the DogStatsD data path and runtime. - A property catalog (35 properties) with per-property evidence files. - A deployment topology, a portfolio evaluation, property relationships, and a bug ledger that maps each discovered defect to how it is reproduced. Docs only, no code. The internal design-partner codename is scrubbed and an internal Antithesis run id is redacted; Confluence links and Jira references are kept. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? Docs only. `check-docs` is unaffected (it builds the `docs/` site; these notes live under `test/`). No code paths change. ## References - Builds on the harness PR (`test/antithesis/`) in this stack. - The failing bug repros it catalogs are in the bug-tests PR in this stack. - Internal context (kept per repo norms) is in the Confluence/Jira links in each artifact's frontmatter.
fc4bb29 to
3952ec9
Compare

Summary
The Antithesis research artifacts for agent-data-plane, under
test/antithesis/scratchbook/. This isthe analysis behind the harness and the bug repros:
each discovered defect to how it is reproduced.
Docs only, no code. The internal design-partner codename is scrubbed and an internal Antithesis run
id is redacted; Confluence links and Jira references are kept.
Change Type
How did you test this PR?
Docs only.
check-docsis unaffected (it builds thedocs/site; these notes live undertest/).No code paths change.
References
test/antithesis/) in this stack.frontmatter.