Fix initialization order for menu controls by DaKongOlta · Pull Request #9 · DaKongOlta/spacer_x

DaKongOlta · 2025-09-22T01:22:08Z

Summary

declare start light timers alongside the HUD elements that use them to prevent reset helpers from touching undefined state
reorder the race initialization block so leaderboard history, caution presets, and race settings are set up before UI refreshes, avoiding TDZ errors on first load
move the race settings event wiring after the track catalog so rebuilding the minimap no longer crashes the menu

Testing

node --check script.js

https://chatgpt.com/codex/tasks/task_e_68c9d8830d808324adea8afa75f49e4d

sourcery-ai

Sorry @DaKongOlta, your pull request is larger than the review limit of 150000 diff characters

sourcery-ai

New security issues found

sourcery-ai · 2025-09-22T02:21:37Z

+    const startMode = startProc?.value || raceSettings.startProc || 'standing';
+    tags.push(getStartProcedureLabel(startMode));
+    tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
+    eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:37Z

+    const startMode = startProc?.value || raceSettings.startProc || 'standing';
+    tags.push(getStartProcedureLabel(startMode));
+    tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
+    eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');


security (javascript.browser.security.insecure-innerhtml): User controlled data in a eventTraitSummary.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:37Z

+        `<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
+        `<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
+    });
+    gridIntroList.innerHTML = listItems.join('');


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:37Z

+        `<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
+        `<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
+    });
+    gridIntroList.innerHTML = listItems.join('');


security (javascript.browser.security.insecure-innerhtml): User controlled data in a gridIntroList.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:37Z

+    sectorFeed.forEach(item => {
+      const li = document.createElement('li');
+      if (item.className) li.classList.add(item.className);
+      li.innerHTML = `<span class=\"tag\">S${item.sector}</span><span class=\"driver\">#${item.number} ${item.driver}</span><span class=\"value\">${formatSplit(item.time)}${item.label ? ' ' + item.label : ''}</span>`;


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:42Z

+      const container = document.createElement('div');
+      container.className = 'archiveEntry';
+      const header = document.createElement('header');
+      header.innerHTML = `<span>${formatDateTime(entry.timestamp)}</span><span>${entry.trackLabel}</span>`;


security (javascript.browser.security.insecure-innerhtml): User controlled data in a header.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:42Z

+      container.appendChild(podium);
+      if (entry.fastestLap) {
+        const fl = document.createElement('div');
+        fl.className = 'meta';
+        fl.textContent 


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:42Z

+      container.appendChild(podium);
+      if (entry.fastestLap) {
+        const fl = document.createElement('div');
+        fl.className = 'meta';
+        fl.textContent 


security (javascript.browser.security.insecure-innerhtml): User controlled data in a div.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:42Z

+      if (entry.fastestLap) {
+        const fl = document.createElement('div');
+        fl.className = 'meta';
+        fl.textContent 


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:21:42Z

+      if (entry.fastestLap) {
+        const fl = document.createElement('div');
+        fl.className = 'meta';
+        fl.textContent 


security (javascript.browser.security.insecure-innerhtml): User controlled data in a row.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai

New security issues found

sourcery-ai · 2025-09-22T02:39:50Z

+    const startMode = startProc?.value || raceSettings.startProc || 'standing';
+    tags.push(getStartProcedureLabel(startMode));
+    tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
+    eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:50Z

+    const startMode = startProc?.value || raceSettings.startProc || 'standing';
+    tags.push(getStartProcedureLabel(startMode));
+    tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
+    eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');


security (javascript.browser.security.insecure-innerhtml): User controlled data in a eventTraitSummary.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:50Z

+        `<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
+        `<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
+    });
+    gridIntroList.innerHTML = listItems.join('');


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:50Z

+        `<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
+        `<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
+    });
+    gridIntroList.innerHTML = listItems.join('');


security (javascript.browser.security.insecure-innerhtml): User controlled data in a gridIntroList.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:50Z

+    sectorFeed.forEach(item => {
+      const li = document.createElement('li');
+      if (item.className) li.classList.add(item.className);
+      li.innerHTML = `<span class=\"tag\">S${item.sector}</span><span class=\"driver\">#${item.number} ${item.driver}</span><span class=\"value\">${formatSplit(item.time)}${item.label ? ' ' + item.label : ''}</span>`;


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:54Z

+      card.style.border = '1px solid #1e293b';
+      card.style.borderRadius = '10px';
+      card.style.padding = '8px';
+


security (javascript.browser.security.insecure-innerhtml): User controlled data in a header.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:54Z

+      const card = document.createElement('div');
+      card.style.border = '1px solid #1e293b';
+      card.style.borderRadius = '10px';
+      card.style.padding = '8px';
+


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:54Z

+      const card = document.createElement('div');
+      card.style.border = '1px solid #1e293b';
+      card.style.borderRadius = '10px';
+      card.style.padding = '8px';
+


security (javascript.browser.security.insecure-innerhtml): User controlled data in a div.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:54Z

+      card.style.border = '1px solid #1e293b';
+      card.style.borderRadius = '10px';
+      card.style.padding = '8px';
+


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T02:39:54Z

+      card.style.border = '1px solid #1e293b';
+      card.style.borderRadius = '10px';
+      card.style.padding = '8px';
+


security (javascript.browser.security.insecure-innerhtml): User controlled data in a row.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai

New security issues found

sourcery-ai · 2025-09-22T03:58:29Z

+  }
+
+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+  }
+
+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-innerhtml): User controlled data in a card.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-innerhtml): User controlled data in a header.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+
+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+
+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-innerhtml): User controlled data in a div.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

sourcery-ai · 2025-09-22T03:58:29Z

+  function renderTeams() {
+    if (!teamsList) return;
+    teamsList.innerHTML = '';
+    Object.entries(managerState.teams).forEach(([team, da


security (javascript.browser.security.insecure-innerhtml): User controlled data in a row.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Fix initialization order for menu controls

8976ca6

DaKongOlta added the codex label Sep 22, 2025 — with ChatGPT Codex Connector

sourcery-ai Bot reviewed Sep 22, 2025

View reviewed changes

DaKongOlta added 3 commits September 21, 2025 19:21

Document v0.9 demo checklist

9526cd0

Add City GP and Canyon Sprint circuits

010b3f7

Add battle spotlight overlay to broadcast HUD

dcb4e90

sourcery-ai Bot requested changes Sep 22, 2025

View reviewed changes

Polish codex caution summary formatting

09b91fa

sourcery-ai Bot requested changes Sep 22, 2025

View reviewed changes

Ensure race controls toggle disabled state reliably

3b7d0d4

sourcery-ai Bot requested changes Sep 22, 2025

View reviewed changes

Ensure Grand Prix prep runs before starting and save on exit

290570a

Conversation

DaKongOlta commented Sep 22, 2025

Summary

Testing

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!