safd#17
Conversation
…-for-space-glider Add Vanguard concept art set for new Spacer-X circuits
…-for-space-glider-ne2qc6 Expand Spacer-X lore compendium
…spacer_x-game-g3hr0p Ensure race screen controls reset cleanly
There was a problem hiding this comment.
Sorry @DaKongOlta, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e4e1b5076
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const browser = await chromium.launch(); | ||
| const page = await browser.newPage(); |
There was a problem hiding this comment.
Move browser launch inside the cleanup guard
If chromium.launch() fails (for example on fresh CI agents where Playwright browsers are not installed), execution throws before entering the try block, so the HTTP server created just above is never closed and npm test can hang until an external timeout. Wrapping browser/page creation in the guarded section (or adding a wider try/finally around the server lifecycle) ensures the process terminates cleanly on launch failures.
Useful? React with 👍 / 👎.
No description provided.