Skip to content

safd#17

Open
DaKongOlta wants to merge 14 commits into
codex/add-manager_save_version-and-migrate-datafrom
main
Open

safd#17
DaKongOlta wants to merge 14 commits into
codex/add-manager_save_version-and-migrate-datafrom
main

Conversation

@DaKongOlta

Copy link
Copy Markdown
Owner

No description provided.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @DaKongOlta, your pull request is larger than the review limit of 150000 diff characters

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e4e1b5076

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +52 to +53
const browser = await chromium.launch();
const page = await browser.newPage();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move browser launch inside the cleanup guard

If chromium.launch() fails (for example on fresh CI agents where Playwright browsers are not installed), execution throws before entering the try block, so the HTTP server created just above is never closed and npm test can hang until an external timeout. Wrapping browser/page creation in the guarded section (or adding a wider try/finally around the server lifecycle) ensures the process terminates cleanly on launch failures.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant