Skip to content

Align race schedules with track catalog data#10

Open
DaKongOlta wants to merge 2 commits into
mainfrom
codex/continue-development-on-spacer_x-game-91cp6n
Open

Align race schedules with track catalog data#10
DaKongOlta wants to merge 2 commits into
mainfrom
codex/continue-development-on-spacer_x-game-91cp6n

Conversation

@DaKongOlta

Copy link
Copy Markdown
Owner

Summary

  • rebuild the manager season calendar from the loaded track catalog and clamp stored weeks against the new rotation
  • extend the Grand Prix rotation sanitiser to repopulate missing venues from the catalog and refresh affected UI flows
  • document the data-driven track selector in the README and mark the checklist item for the JSON loader as complete

Testing

  • node --check script.js

https://chatgpt.com/codex/tasks/task_e_68c9d8830d808324adea8afa75f49e4d

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @DaKongOlta, your pull request is larger than the review limit of 150000 diff characters

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

Comment thread script.js
const startMode = startProc?.value || raceSettings.startProc || 'standing';
tags.push(getStartProcedureLabel(startMode));
tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
const startMode = startProc?.value || raceSettings.startProc || 'standing';
tags.push(getStartProcedureLabel(startMode));
tags.push(aiLabels[aiLevel] || `KI: ${aiLevel}`);
eventTraitSummary.innerHTML = tags.map(tag => `<span>${tag}</span>`).join('');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-innerhtml): User controlled data in a eventTraitSummary.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
`<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
`<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
});
gridIntroList.innerHTML = listItems.join('');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
`<span>PaceIdx ${paceIndex} • Form ${formText} • Morale ${moralePct}%</span>` +
`<span>Driver Stats P${paceStat} | I${intelStat} | C${consistStat} | R${riskStat}</span></li>`;
});
gridIntroList.innerHTML = listItems.join('');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-innerhtml): User controlled data in a gridIntroList.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
sectorFeed.forEach(item => {
const li = document.createElement('li');
if (item.className) li.classList.add(item.className);
li.innerHTML = `<span class=\"tag\">S${item.sector}</span><span class=\"driver\">#${item.number} ${item.driver}</span><span class=\"value\">${formatSplit(item.time)}${item.label ? ' ' + item.label : ''}</span>`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
warmupAudio();
replaySpeed = parseFloat(replaySpeedSelect?.value || '1') || 1;
if (countdownTimer) {
clearIn

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-innerhtml): User controlled data in a header.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
Comment on lines +6164 to +6919
recordingReplay = true;
warmupAudio();
replaySpeed = parseFloat(replaySpeedSelect?.value || '1') || 1;
if (countdownTimer) {
clearIn

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
Comment on lines +6164 to +6919
recordingReplay = true;
warmupAudio();
replaySpeed = parseFloat(replaySpeedSelect?.value || '1') || 1;
if (countdownTimer) {
clearIn

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-innerhtml): User controlled data in a div.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
warmupAudio();
replaySpeed = parseFloat(replaySpeedSelect?.value || '1') || 1;
if (countdownTimer) {
clearIn

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-document-method): User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Comment thread script.js
warmupAudio();
replaySpeed = parseFloat(replaySpeedSelect?.value || '1') || 1;
if (countdownTimer) {
clearIn

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (javascript.browser.security.insecure-innerhtml): User controlled data in a row.innerHTML is an anti-pattern that can lead to XSS vulnerabilities

Source: opengrep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant