Skip to content

🛡️ Sentinel: [MEDIUM] Fix stack trace leakage in telemetry #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHCross merged 1 commit into from
Jun 29, 2026
+2 −2
Merged

🛡️ Sentinel: [MEDIUM] Fix stack trace leakage in telemetry #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vessel/src/app/api/raven-chat/enrichmentPhase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function describeEnrichmentError(error: unknown): Record<string, unknown> {
record.status = error.status;
record.retryAfterMs = error.retryAfterMs;
}
if (error instanceof Error && error.stack) {
if (error instanceof Error && error.stack && process.env.NODE_ENV !== 'production') {
record.stackTop = error.stack.split('\n').slice(0, 4).join('\n');
}
return record;
Expand Down
2 changes: 1 addition & 1 deletion vessel/src/app/api/raven-chat/upstreamContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
if (maybeStatus.status !== undefined) record.status = maybeStatus.status;
if (maybeStatus.retryAfterMs !== undefined) record.retryAfterMs = maybeStatus.retryAfterMs;
}
if (error instanceof Error && error.stack) {
if (error instanceof Error && error.stack && process.env.NODE_ENV !== 'production') {
record.stackTop = error.stack.split('\n').slice(0, 4).join('\n');
}
return record;
Expand Down Expand Up @@ -146,7 +146,7 @@

// ── Astrology fetch ──
let astrology: ChatGeometryContext | null = null;
let horoscopeContrast: string | null = null;

Check failure on line 149 in vessel/src/app/api/raven-chat/upstreamContext.ts

View workflow job for this annotation

GitHub Actions / Advisory Lint Check 

'horoscopeContrast' is never reassigned. Use 'const' instead
let momentArcSynthesis: MomentArcSynthesis | null = null;
let astrologyError: string | null = null;
const allowSymbolicWeatherForTurn = promptMode === 'CREATOR_MIRROR'
Expand Down
Loading