🛡️ Sentinel: [MEDIUM] Fix stack trace leakage in telemetry#885
Conversation
- Conditionally strips `error.stack` based on `process.env.NODE_ENV !== 'production'` in `vessel/src/app/api/raven-chat/enrichmentPhase.ts` and `vessel/src/app/api/raven-chat/upstreamContext.ts`. - Prevents potential information disclosure of internal file paths and structures in production.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: Information disclosure via leaking stack traces. The
enrichmentPhase.tsandupstreamContext.tsfunctions were unconditionally slicing and appendingerror.stackinto logs/records.🎯 Impact: Attackers or unauthorized viewers can access internal file structures, library versions, and application details when error telemetry is exposed.
🔧 Fix: Wrapped the
error.stacklogic with aprocess.env.NODE_ENV !== 'production'check so stack traces are safely stripped in production environments.✅ Verification: Ensure the test suites run normally (
npx tsx --tsconfig tsconfig.test.json --test src/app/api/raven-chat/__tests__/llmProviderStream.test.tspassed) and manually verify that no regressions occur with telemetry logging.PR created automatically by Jules for task 8232247008822935663 started by @DHCross