feat: support flagged describe#284
Open
NullVoxPopuli wants to merge 1 commit into
Open
Conversation
NullVoxPopuli
force-pushed
the
flagged-describe
branch
2 times, most recently
from
d5a2ee1 to
efbcf27
Compare
Author
|
looks like |
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
efbcf27 to
6d7084a
Compare
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
6d7084a to
cfe7389
Compare
kellyselden
requested changes
May 13, 2020
kellyselden
left a comment
kellyselden
left a comment
Contributor
There was a problem hiding this comment.
What happens when a describe has flags and an inner it has additional flags?
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
cfe7389 to
06f5ff9
Compare
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
7e6c04d to
14431cc
Compare
kellyselden
requested changes
Jun 15, 2020
kellyselden
left a comment
kellyselden
left a comment
Contributor
There was a problem hiding this comment.
Still needs tests? To see how it is used and if it works.
NullVoxPopuli
added a commit
to NullVoxPopuli/faltest
that referenced
this pull request
Aug 14, 2020
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
14431cc to
2333a91
Compare
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
71617be to
95227da
Compare
NullVoxPopuli
force-pushed
the
flagged-describe
branch
from
95227da to
d147dd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a todo, I still need to test if this works