feat: add flagged describe#432
Closed
victormejia wants to merge 1 commit into
Closed
Conversation
victormejia
force-pushed
the
flagged-describe
branch
from
af18e5d to
7ecf239
Compare
kellyselden
requested changes
Feb 6, 2021
kellyselden
left a comment
kellyselden
left a comment
Contributor
There was a problem hiding this comment.
Some notes:
- you should cherry pick Preston's commit first so authorship is retained.
- this needs new tests to verify the feature works
- We should also retain the old
createFlaggedTestexport name to prevent a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grabbing existing changes from #284 and fixed tests.