Replace docking framework#941
Merged
Merged
Conversation
Only active when specific launch parameters are provided
I was really hoping this would fix the white flash of death, but it hasn't. At least we know the problem is seemingly not also based on our docking usage...
To find more issues, try out Recaf features with the access agent enabled. Example: -javaagent:javafx-access-agent-1.0.4.jar=software/;org/;com/;javafx/
Its required when using https://github.com/JonathanGiles/scenic-view and I forgot to remove it in prior commits
Col-E
added
enhancement
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
=========================================
Coverage 62.70% 62.70%
- Complexity 3910 3911 +1
=========================================
Files 385 385
Lines 16546 16548 +2
Branches 2736 2736
=========================================
+ Hits 10375 10377 +2
Misses 4816 4816
Partials 1355 1355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Col-E
commented
Jun 10, 2025
Col-E
commented
Jun 10, 2025
Col-E
commented
Jun 10, 2025
Col-E
commented
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI Comparison
Left is with Bento. Right is the existing solution with TiwulFX.
New features
Clicking on tabs that occupy the full width/height of a split will collapse them. This lets you free up space quickly while keeping those tabs one click away.
Where things will get split should be more intuitive now. Here is another comparison when dragging the
Bootstrapclass.