Light theme option

[stevenxxiu]

From my previous issue #779, I saw that v2 wasn't supported anymore. I tried the latest commit in the dev4 branch, 9653c52, today, but found no theme option.

Could there be a light theme?

I understand you prefer dark themes, but there's people who prefer light themes too. It'll make this so much easier to use.

[stevenxxiu]

I made a few patches to get light theme working. The patched files are:

• recaf-ui/src/main/resources/style/code-editor.css
• recaf-ui/src/main/resources/style/recaf.css
• recaf-ui/src/main/resources/style/tweaks.css
• recaf-ui/src/main/resources/syntax/

The syntax highlighting colors use Catppuccin Latte colors, except for Javadoc.

Maybe there could be an option to use a custom theme via CSS files? This way the theme doesn't have to be hardcoded.

A screenshot of what my patches look like:

[Col-E]

Eventually we'll add file watching in the style directory and re-apply changes to windows, but its not been a priority item.

[Logarithmus]

@stevenxxiu hello, I'm very interested in your patch, since Recaf default theme makes it hard to work on sunny summer days, I have to ramp up my screen brightness to max to see anything, but then the browser's white background burns my eyes... Where can I find your patch? Thanks in advance for your work

[stevenxxiu]

@Logarithmus I haven't put it on GitHub. I can upload it, but I'm not sure if it works. I'm still waiting on #933, as I otherwise can't build Recaf rn.

[Logarithmus]

@stevenxxiu ok, please share it if you have spare time. BTW, it's possible to have several JDK versions installed on one PC

[Col-E]

For SA, I recently swapped out our docking framework in #941

This will require some updates to the CSS as we're no longer using things like .tab-pane and .tab (built in controls) for docking. I'm still ironing out the new docking system so I anticipate a few more CSS/scene graph hierarchy changes with it over the next week. At some later point when I'm pretty sure that I'm done making significant UI changes that require tweaking the existing theme, I'd accept a PR with a light theme option/toggle.

[stevenxxiu]

@Logarithmus I've gotten it to build with the latest JDK, updated my patches, uploaded it to https://github.com/stevenxxiu/package-recaf-git.

@Col-E As you can see I need to patch AtlantaFX too. Is there some easy way to integrate my patches?

[Col-E]

CSS is additive, so if you override values in a file added later the value gets replaced. tweaks.css modifies some of AtlantaFX's properties for instance.