Skip to content

fix: add rate limiting to non-friends leaderboard scopes #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
namann5 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add rate limiting to non-friends leaderboard scopes #688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7d66d
fix: add rate limiting to non-friends leaderboard scopes
namann5 Jul 11, 2026
aed452b
fix: move rate limit inside cache check, use RATE_LIMIT_TIERS.STANDARD
namann5 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/actions/leaderboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { ok, err, type Result } from '@/lib/result';
import { getServerSupabase } from '@/lib/supabase/server';
import { getAppOctokit, getInstallOctokit } from '@/lib/github/app';
import { requireUser } from '@/lib/action-auth';
import { RATE_LIMIT_TIERS } from '@/lib/rate-limit';

export type LeaderboardScope = 'global' | 'cohort' | 'language' | 'tag' | 'monthly' | 'friends';

Expand Down Expand Up @@ -136,6 +137,15 @@ export async function getLeaderboard(
}[] = [];

if (!cached) {
// Rate-limit non-friends scopes to prevent database resource exhaustion.
if (scope !== 'friends') {
const rlRes = await requireUser({
rateLimit: { namespace: 'leaderboard', ...RATE_LIMIT_TIERS.STANDARD },
rateLimitMessage: 'too many leaderboard requests, slow down',
});
if (!rlRes.ok) return rlRes;
}

if (scope === 'global') {
rows = (await db.execute(sql`
select id, github_handle, display_name, avatar_url, xp, level, github_total_merges, github_streak,
Expand Down