fix: add rate limiting to non-friends leaderboard scopes#688
Open
namann5 wants to merge 1 commit into
Open
Conversation
Closes Coder-s-OG-s#657 Only the friends scope had rate limiting via requireUser. All other scopes (global, cohort, language, tag, monthly) could be called at high frequency, enabling database resource exhaustion. Added a shared rate limit (30 req/60s) for non-friends scopes before any expensive DB queries execute.
Contributor
|
@namann5 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
jakharmonika364
requested changes
Jul 12, 2026
Comment on lines
+128
to
+132
| if (scope !== 'friends') { | ||
| const rlRes = await requireUser({ | ||
| rateLimit: { namespace: 'leaderboard', limit: 30, windowSec: 60 }, | ||
| rateLimitMessage: 'too many leaderboard requests, slow down', | ||
| }); |
Collaborator
There was a problem hiding this comment.
this rate limit check runs before the cache check, so cache hits get throttled too even though they don't touch the db. the friends scope below (line ~190) does it right - rate limit is inside the if (!cached) block, at the point the query actually happens. move this one in there too.
also RATE_LIMIT_TIERS is imported but unused, the {limit:30, windowSec:60} you hardcoded is literally RATE_LIMIT_TIERS.STANDARD, just use that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds rate limiting to all non-friends leaderboard scopes (\global, \cohort, \language, \ ag, \monthly) in \getLeaderboard.
Problem
Only the \ riends\ scope had rate limiting via
equireUser. All other scopes could be called at high frequency, enabling:
Fix
Added a shared rate limit (30 requests per 60 seconds) for non-friends scopes, applied before any database queries execute. This uses the same
equireUser\ +
ateLimit\ pattern already used for the \ riends\ scope.
The \ riends\ scope retains its existing separate rate limit (10 req/60s) which is stricter due to the additional GitHub API call overhead.
Testing
pm run lint\ passes
pm run typecheck\ passes (pre-existing @google/genai\ error only)
Closes #657