Skip to content

🛡️ Sentinel: [CRITICAL] Fix SQL injection via sql.raw in jsonExtract #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Donach wants to merge 1 commit into
base: cfx/android-hermes-client
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix SQL injection via sql.raw in jsonExtract #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/src/db/database-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,14 @@ export function jsonExtract(db: Database, column: SQL.Aliased | SQL | any, path:
} else {
// PostgreSQL: column->'path'->'to'->>'field'
// Use -> for all but the last part (keeps as JSON), ->> for the last part (extracts as text)
// IMPORTANT: Use sql.raw() for JSON keys to avoid parameterization
if (parts.length === 1) {
// Single level: column->>'key'
return sql`${column}${sql.raw(`->>'${parts[0]}'`)}`;
return sql`${column} ->> (${parts[0]}::text)`;
} else {
// Multiple levels: column->'key1'->'key2'->>'key3'
const objectParts = parts.slice(0, -1).map((p) => sql.raw(`->'${p}'`));
const objectParts = parts.slice(0, -1).map((p) => sql`-> (${p}::text)`);
const lastPart = parts[parts.length - 1];
return sql`${column}${sql.join(objectParts, sql``)}${sql.raw(`->>'${lastPart}'`)}`;
return sql`${column} ${sql.join(objectParts, sql` `)} ->> (${lastPart}::text)`;
}
}
}
Expand Down