Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection via sql.raw in jsonExtract - #166

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-sql-injection-jsonextract-8106088060992392657
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection via sql.raw in jsonExtract#166
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-sql-injection-jsonextract-8106088060992392657

Conversation

@Donach

@Donach Donach commented Aug 2, 2026

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The jsonExtract utility function used sql.raw to construct dynamic PostgreSQL JSON extraction paths, bypassing query parameterization and exposing the application to SQL injection if untrusted inputs were passed as the JSON path.
🎯 Impact: An attacker could craft a malicious JSON path string that alters the structure of the database query, potentially leading to unauthorized data disclosure, modification, or deletion.
πŸ”§ Fix: Rewrote the jsonExtract function to use Drizzle's proper parameterization by explicitly casting dynamic parameters to ::text (e.g. ->> (${parts[0]}::text)) along with sql.join to safely build multi-level path extractions.
βœ… Verification: Run pnpm --filter @agor/core test and verify that all core database tests pass and no new warnings appear.


PR created automatically by Jules for task 8106088060992392657 started by @Donach

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant