π‘οΈ Sentinel: [CRITICAL] Fix SQL injection via sql.raw in jsonExtract - #166
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
jsonExtractutility function usedsql.rawto construct dynamic PostgreSQL JSON extraction paths, bypassing query parameterization and exposing the application to SQL injection if untrusted inputs were passed as the JSON path.π― Impact: An attacker could craft a malicious JSON path string that alters the structure of the database query, potentially leading to unauthorized data disclosure, modification, or deletion.
π§ Fix: Rewrote the
jsonExtractfunction to use Drizzle's proper parameterization by explicitly casting dynamic parameters to::text(e.g.->> (${parts[0]}::text)) along withsql.jointo safely build multi-level path extractions.β Verification: Run
pnpm --filter @agor/core testand verify that all core database tests pass and no new warnings appear.PR created automatically by Jules for task 8106088060992392657 started by @Donach