Expand Sentry release artifact verification#103
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands repo-side verification of the Sentry release artifact workflow by adding a Vitest “contract test” that asserts key workflow/config invariants, and extends SENTRY.md with an owner-side manual dispatch and verification checklist. This helps keep Spec 21 release-artifact handling stable without requiring Sentry secrets during routine CI runs.
Changes:
- Add
src/observability/sentryReleaseArtifacts.test.tsto validate workflow wiring, Vite Sentry sourcemap behavior, Android/desktop debug upload hooks, andconfigure-sentry-release-env.shpositive/negative cases. - Document an owner-side manual
gh workflow rundispatch flow and a Sentry-side verification checklist inSENTRY.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/observability/sentryReleaseArtifacts.test.ts |
Adds Vitest coverage that verifies Sentry release artifact workflow/script/config invariants and error handling. |
SENTRY.md |
Documents owner-side manual dispatch and post-run Sentry verification checklist for release artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds deeper repo-side verification for Spec 21 Sentry release artifact handling and documents the owner-side manual dispatch path. The new Vitest coverage executes
.github/scripts/configure-sentry-release-env.shfor positive and negative cases, and pins the workflow/config invariants for frontend sourcemaps, desktop/Apple debug-file uploads, Android mapping/native-symbol upload, and Android Size Analysis.Related to #101, #83, #85, #87, #95, and #96.
What still requires owner-side Sentry secrets or a real run:
SENTRY_AUTH_TOKEN,SENTRY_ORG,SENTRY_PROJECT, andVITE_SENTRY_DSN.sentry-release-artifacts.ymlviaworkflow_dispatchor av*tag so Sentry actually accepts the uploads.Suggested manual workflow dispatch after merge:
For a tag release:
Expected Sentry-side verification checklist:
charmproject and process without unresolved upload errors.Releasebuild configuration and base SHA.Validation
actionlint .github/workflows/sentry-release-artifacts.ymlbash -n .github/scripts/configure-sentry-release-env.shnode --check .github/scripts/report-artifact-sizes.mjsnode_modules/.bin/vitest run src/observability/sentryReleaseArtifacts.test.tsnode_modules/.bin/oxlint .(passes with existing warnings)node_modules/.bin/oxfmt --check .node_modules/.bin/tsc --noEmitnode_modules/.bin/vitest run --coveragenode_modules/.bin/knipnode_modules/.bin/tsc && node_modules/.bin/vite buildNote: I did not run
pnpm installor change dependencies. The fresh worktree reused the existing localnode_modulesvia an ignored symlink for validation only because this worktree started dependency-clean.