Skip to content

Expand Sentry release artifact verification#103

Merged
Just-Insane merged 2 commits into
mainfrom
fix/spec21-sentry-release-artifacts
Jul 9, 2026
Merged

Expand Sentry release artifact verification#103
Just-Insane merged 2 commits into
mainfrom
fix/spec21-sentry-release-artifacts

Conversation

@Just-Insane

Copy link
Copy Markdown
Contributor

Description

Adds deeper repo-side verification for Spec 21 Sentry release artifact handling and documents the owner-side manual dispatch path. The new Vitest coverage executes .github/scripts/configure-sentry-release-env.sh for positive and negative cases, and pins the workflow/config invariants for frontend sourcemaps, desktop/Apple debug-file uploads, Android mapping/native-symbol upload, and Android Size Analysis.

Related to #101, #83, #85, #87, #95, and #96.

What still requires owner-side Sentry secrets or a real run:

  • Configure or confirm Actions secrets: SENTRY_AUTH_TOKEN, SENTRY_ORG, SENTRY_PROJECT, and VITE_SENTRY_DSN.
  • Run sentry-release-artifacts.yml via workflow_dispatch or a v* tag so Sentry actually accepts the uploads.
  • Verify in Sentry that the selected release has frontend source maps/debug IDs, processed Linux/macOS/Windows/iOS simulator debug files, Android ProGuard/R8 mapping and native symbols, and Android Size Analysis output.

Suggested manual workflow dispatch after merge:

gh workflow run sentry-release-artifacts.yml \
  --ref main \
  -f release=charm@2.0.0-rc.1 \
  -f environment=production

For a tag release:

gh workflow run sentry-release-artifacts.yml \
  --ref v2.0.0 \
  -f environment=production

Expected Sentry-side verification checklist:

  • The selected release exists and has frontend artifacts with debug IDs/source maps for built JavaScript chunks.
  • Linux, macOS, Windows, and iOS simulator debug files appear under the charm project and process without unresolved upload errors.
  • Android ProGuard/R8 mapping and native symbols are associated with the release artifact build.
  • Android Size Analysis has an APK/AAB build for the selected run with the configured Release build configuration and base SHA.
  • GitHub uploaded frontend, Linux, Apple, Windows, and Android size-report artifacts for the run.

Validation

  • actionlint .github/workflows/sentry-release-artifacts.yml
  • bash -n .github/scripts/configure-sentry-release-env.sh
  • node --check .github/scripts/report-artifact-sizes.mjs
  • node_modules/.bin/vitest run src/observability/sentryReleaseArtifacts.test.ts
  • node_modules/.bin/oxlint . (passes with existing warnings)
  • node_modules/.bin/oxfmt --check .
  • node_modules/.bin/tsc --noEmit
  • node_modules/.bin/vitest run --coverage
  • node_modules/.bin/knip
  • node_modules/.bin/tsc && node_modules/.bin/vite build

Note: I did not run pnpm install or change dependencies. The fresh worktree reused the existing local node_modules via an ignored symlink for validation only because this worktree started dependency-clean.

@Just-Insane Just-Insane temporarily deployed to cloudflare-preview July 9, 2026 12:06 — with GitHub Actions Inactive
@Just-Insane Just-Insane marked this pull request as ready for review July 9, 2026 12:09
Copilot AI review requested due to automatic review settings July 9, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands repo-side verification of the Sentry release artifact workflow by adding a Vitest “contract test” that asserts key workflow/config invariants, and extends SENTRY.md with an owner-side manual dispatch and verification checklist. This helps keep Spec 21 release-artifact handling stable without requiring Sentry secrets during routine CI runs.

Changes:

  • Add src/observability/sentryReleaseArtifacts.test.ts to validate workflow wiring, Vite Sentry sourcemap behavior, Android/desktop debug upload hooks, and configure-sentry-release-env.sh positive/negative cases.
  • Document an owner-side manual gh workflow run dispatch flow and a Sentry-side verification checklist in SENTRY.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/observability/sentryReleaseArtifacts.test.ts Adds Vitest coverage that verifies Sentry release artifact workflow/script/config invariants and error handling.
SENTRY.md Documents owner-side manual dispatch and post-run Sentry verification checklist for release artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/observability/sentryReleaseArtifacts.test.ts Outdated
Comment thread src/observability/sentryReleaseArtifacts.test.ts Outdated
Comment thread src/observability/sentryReleaseArtifacts.test.ts Outdated
@Just-Insane Just-Insane enabled auto-merge July 9, 2026 12:11
Copilot AI review requested due to automatic review settings July 9, 2026 12:17
@Just-Insane Just-Insane temporarily deployed to cloudflare-preview July 9, 2026 12:17 — with GitHub Actions Inactive
@Just-Insane Just-Insane added this pull request to the merge queue Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/observability/sentryReleaseArtifacts.test.ts
Merged via the queue into main with commit 544f155 Jul 9, 2026
31 checks passed
@Just-Insane Just-Insane deleted the fix/spec21-sentry-release-artifacts branch July 9, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants