Harden Sentry release env test cleanup#104
Merged
Merged
Conversation
Just-Insane
had a problem deploying
to
cloudflare-preview
GitHub Actions
Error
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #103. Addresses the remaining post-merge Copilot review thread by wrapping the
configureSentryReleaseEnvtemp-directory lifecycle intry/finally, so the temporary$GITHUB_ENVdirectory is removed even if an unexpected read throws after the helper exits successfully.This is test-only cleanup; no runtime behavior changes.
Validation
node_modules/.bin/oxfmt --check src/observability/sentryReleaseArtifacts.test.tsnode_modules/.bin/vitest run src/observability/sentryReleaseArtifacts.test.tsnode_modules/.bin/oxlint src/observability/sentryReleaseArtifacts.test.tsnode_modules/.bin/tsc --noEmitAI disclosure