Verify Sentry release artifact handling#101
Closed
Just-Insane wants to merge 4 commits into
Closed
Conversation
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a repo-side “contract test” to statically verify the Sentry release-artifacts workflow wiring (without needing real Sentry secrets locally) and updates SENTRY.md with an owner-side manual dispatch + verification checklist.
Changes:
- Add a Vitest test that asserts the Sentry release workflow, env-script, Vite config, and Android Gradle settings remain wired for artifact/sourcemap/symbol/size uploads.
- Document the owner-side
gh workflow runmanual verification path and a Sentry-side checklist inSENTRY.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/observability/sentryReleaseArtifactsWorkflow.test.ts | New contract test that inspects workflow/config/script files to verify Sentry release artifact wiring stays intact. |
| SENTRY.md | Adds owner-side manual dispatch instructions and post-run verification checklist for Sentry release artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Just-Insane
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Comment on lines
+1
to
+20
| import { readFileSync } from "node:fs"; | ||
| import { resolve } from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| describe("Sentry release artifact workflow", () => { | ||
| const root = process.cwd(); | ||
| const workflow = readFileSync( | ||
| resolve(root, ".github/workflows/sentry-release-artifacts.yml"), | ||
| "utf8", | ||
| ); | ||
| const viteConfig = readFileSync(resolve(root, "vite.config.ts"), "utf8"); | ||
| const releaseEnvScript = readFileSync( | ||
| resolve(root, ".github/scripts/configure-sentry-release-env.sh"), | ||
| "utf8", | ||
| ); | ||
| const androidAppBuild = readFileSync( | ||
| resolve(root, "src-tauri/gen/android/app/build.gradle.kts"), | ||
| "utf8", | ||
| ); | ||
|
|
Comment on lines
+23
to
+24
| expect(workflow).toMatch(/release:\r?\n\s+description: "Sentry release name\./); | ||
| expect(workflow).toMatch(/environment:\r?\n\s+description: "Sentry environment tag/); |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds repo-side verification for the Sentry release artifact workflow and documents the owner-side manual dispatch path. This confirms the current workflow wiring covers frontend sourcemaps, desktop/Apple debug files, Android mapping/native-symbol upload, and Android Size Analysis inputs without requiring real Sentry secrets locally.
Related to #83, #85, #87, #95, and #96.
What still requires owner-side Sentry access:
SENTRY_AUTH_TOKEN,SENTRY_ORG,SENTRY_PROJECT, andVITE_SENTRY_DSN.workflow_dispatchorv*tag workflow so Sentry accepts uploads.Suggested manual smoke command after merge:
gh workflow run sentry-release-artifacts.yml \ --ref main \ -f release=manual-sentry-artifact-smoke-$(git rev-parse --short HEAD) \ -f environment=productionExpected Sentry-side verification checklist:
distchunks.Type of change
Checklist:
pnpm lint,pnpm fmt:check,pnpm typecheck,pnpm test:coverage,pnpm knip, andpnpm buildall pass locallyAdditional local/static validation:
actionlint .github/workflows/sentry-release-artifacts.ymlbash -n .github/scripts/configure-sentry-release-env.shSENTRY_RELEASE,SENTRY_UPLOAD,VITE_SENTRY_RELEASE,SENTRY_ENVIRONMENT, andVITE_SENTRY_ENVIRONMENT.SENTRY_RELEASEandCARGO_PROFILE_RELEASE_DEBUG=1.VITE_SENTRY_DSNfails closed with::error::Missing required Sentry secret(s): VITE_SENTRY_DSN.AI disclosure: