Research panel + roadmap; implement top items#7
Conversation
Review verdict — 2026-07-09: READY TO MERGE (verified locally; CI billing-blocked)Adversarial review of the full diff vs What was pushed (2 commits):
Review findings (all clean):
Local gate evidence (CI is billing-blocked account-wide — local runs are the review gate for this repo): Merging this also lands F1/F2 essentially for free and fixes the portfolio index's dangling link to 🤖 Generated with Claude Code |
Review finding on FIX-09: KNOWN_STACKS_ENV is a hand-maintained allowlist, so the moment a new STACKS_* variable ships (e.g. PR #7's STACKS_HIDE_SENSITIVE), 'stacks doctor' would false-flag the legitimate variable as a typo — the exact failure mode the allowlist exists to prevent. New test scans the quoted STACKS_* literals in app/ingest/ recommender source and asserts set-equality with KNOWN_STACKS_ENV, so the drift becomes a red test instead of a silent lie. Artifacts regenerated. make verify green: 204 tests @ 96.67% cov, pa11y 0, eval green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds two research deliverables and implements the highest-leverage, self-contained items from the roadmap: - docs/USER-RESEARCH.md — synthetic stakeholder panel (clearly labelled synthetic; not evidence of demand; every "values today" maps to a real feature) - docs/RESEARCH-ROADMAP.md — cited, triaged roadmap (remediation + expansion backlogs, sequencing, persona traceability, external evidence) See the "Implementation status - 2026-06-30" record in docs/RESEARCH-ROADMAP.md (or the inline "Implemented" annotations) for exactly what shipped and the local verification result. Human/key/infra-gated items were deferred, not faked. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The fetch-etiquette section claimed the whole policy was 'enforced by etiquette_headers + ResponseCache'. True for User-Agent, public-metadata- only, caching, and the host allowlist — but robots.txt honouring and 429/5xx backoff are not implemented in any client yet (the live clients are pragma: no cover network paths; backoff/robots are planned with the FIX-01 candidate pipeline + PR #27 cassettes). The compliance doc now distinguishes enforced-in-code rules from committed-policy-pending-code, matching the repo's no-overclaiming posture. docs/ethical-book-data- sources.md regenerated from to_markdown(); coverage.xml regenerated. make verify green: 210 tests, 96.67% branch coverage, pa11y 0, eval green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
e945a94 to
7018e00
Compare
|
Rebased onto current `main` (resolved conflicts in `app/server.py` — kept main's module-level route-handler refactor with `/livez` `/version` `/readyz`, and re-applied this PR's `hide_sensitive` query-param plumbing on top of it — plus a generated-file conflict in `docs/audits/coverage.xml`, resolved by taking main's copy since it's a build artifact) and force-pushed. Both CI checks (`ci` / `verify` and `standards`) are failing repo-wide right now, completing in ~3s with zero steps executed — this matches every other open PR in the queue as of this run, so it's an infrastructure-level failure (consistent with the account-billing block on GitHub Actions mentioned in this PR's description), not something caused by this PR's diff. Not merging until that's resolved; will need a maintainer to fix Actions billing/runner availability before any PR here can go green. |
|
Automated merge pass: unable to proceed. Both required checks ( |
Review finding on FIX-09: KNOWN_STACKS_ENV is a hand-maintained allowlist, so the moment a new STACKS_* variable ships (e.g. PR #7's STACKS_HIDE_SENSITIVE), 'stacks doctor' would false-flag the legitimate variable as a typo — the exact failure mode the allowlist exists to prevent. New test scans the quoted STACKS_* literals in app/ingest/ recommender source and asserts set-equality with KNOWN_STACKS_ENV, so the drift becomes a red test instead of a silent lie. Artifacts regenerated. make verify green: 204 tests @ 96.67% cov, pa11y 0, eval green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Summary
Adds a synthetic user-research panel and a cited research roadmap, and implements the highest-leverage self-contained items from that roadmap.
docs/USER-RESEARCH.md— synthetic stakeholder panel covering the full cast (users in varied situations, the people who buy/govern/fund, independent auditors, adversaries where relevant, and the owner). Clearly labelled synthetic; every "values today" maps to a feature that actually exists.docs/RESEARCH-ROADMAP.md— remediation + expansion backlogs (ID · personas · priority · effort · evidence), Now/Next/Later sequencing tied to the existing roadmap, a persona→findings traceability matrix, cited external evidence, and an "Implementation status — 2026-06-30" record of what shipped in this PR.Verification
The repo's own gate (
make verify/ equivalent) was re-run locally and is green for the implemented code. Hard guardrails were respected; human/key/infra-gated roadmap items were deliberately deferred.🤖 Generated with Claude Code