ci: add merge-blocking perf gates — Locust p95 smoke + Lighthouse-CI#28
Merged
ChelseaKR merged 2 commits intoJul 12, 2026
Merged
Conversation
Closes the "Performance (Quality §2)" deferred gate: reliability's restart-recovery + kosync-down tests were already merge-blocking via tests/test_reliability.py, but load smoke and Lighthouse-CI were missing. - tests/perf/locustfile.py: a demo-auth Locust scenario hitting `/` and `/readyz`. - scripts/perf-smoke.sh (`make perf-load`): boots the app in demo mode, runs the scenario headlessly, and fails closed if the aggregated p95 is >= 500ms. Verified locally (p95 ~15ms; a threshold=0 run correctly exits non-zero). - .lighthouserc.json (`make lighthouse`): runs Lighthouse-CI against the built docs/audits/dashboard.html with categories:performance >= 0.9 and categories:accessibility >= 1.0 as error-level assertions. - Fixed a real color-contrast bug the new Lighthouse gate caught: app/render.py relied on implicit link-color defaults under `color-scheme: light dark`, which Chrome resolved inconsistently against the page background (2.38:1, needs 4.5:1). Pairing Canvas/CanvasText/LinkText/VisitedText system colors fixes it — both categories now score 1.0. - Wired both as non-conditional, blocking steps in ci.yml; added locust to the dev extra in pyproject.toml. - Marked both roadmap gates done in docs/ROADMAP-FUTURE.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # .github/workflows/ci.yml # Makefile # app/render.py # docs/ROADMAP-FUTURE.md # docs/audits/coverage.xml # docs/audits/dashboard.html
ChelseaKR
force-pushed
the
roadmap/performance-reliability-merge-blocking-g
branch
from
July 12, 2026 08:08
ed63783 to
f48db32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the "Performance (Quality §2)" deferred gate: reliability's
restart-recovery + kosync-down tests were already merge-blocking via
tests/test_reliability.py, but load smoke and Lighthouse-CI were missing.
/and/readyz.make perf-load): boots the app in demo mode,runs the scenario headlessly, and fails closed if the aggregated p95
is >= 500ms. Verified locally (p95 ~15ms; a threshold=0 run correctly
exits non-zero).
make lighthouse): runs Lighthouse-CI against thebuilt docs/audits/dashboard.html with categories:performance >= 0.9
and categories:accessibility >= 1.0 as error-level assertions.
app/render.py relied on implicit link-color defaults under
color-scheme: light dark, which Chrome resolved inconsistentlyagainst the page background (2.38:1, needs 4.5:1). Pairing
Canvas/CanvasText/LinkText/VisitedText system colors fixes it — both
categories now score 1.0.
to the dev extra in pyproject.toml.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Backfill PR for a completed roadmap item (
roadmap/performance-reliability-merge-blocking-g, 1 commit(s) overmain). Part of the portfolio roadmap batch.