Skip to content

Fix GMRF not working with LinearRTO when scalar is passed as mean #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeverink wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix GMRF not working with LinearRTO when scalar is passed as mean #661

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2538064
Set GMRF mean to a vector when scalar passed
jeverink Jun 20, 2025
5f95a32
Fix conditioning on mean with GMRF
jeverink Jun 20, 2025
cbe34ea
Possible fix for initializing GMRF without geometry
jeverink Jun 20, 2025
5ef3874
Undo
jeverink Jun 20, 2025
1fc5b9e
Error for GMRF edge case
jeverink Jun 20, 2025
f9c67ba
Update cuqi/distribution/_gmrf.py
jeverink Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cuqi/distribution/_gmrf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from cuqi.distribution import Distribution
from cuqi.utilities import force_ndarray

import collections

class GMRF(Distribution):
""" Gaussian Markov random field (GMRF).

Expand Down Expand Up @@ -94,6 +96,9 @@ class GMRF(Distribution):
"""

def __init__(self, mean=None, prec=None, bc_type="zero", order=1, **kwargs):
if not isinstance(mean, collections.abc.Iterable) and 'geometry' not in kwargs.keys():
raise ValueError(f"Cannot infer dimension if scalar mean and no supported geometry is provided.")

# Init from abstract distribution class
super().__init__(**kwargs)

Expand Down Expand Up @@ -147,7 +152,12 @@ def mean(self):

@mean.setter
def mean(self, value):
self._mean = force_ndarray(value, flatten=True)
# Force the mean to be an array of proper length.
if isinstance(value, collections.abc.Iterable) or callable(value):
self._mean = force_ndarray(value, flatten=True)
else:
# Direct call to the private '_geometry' as the public 'geometry' tries to infer the dimension using the variable we currently setting.
self._mean = value*np.ones(self._geometry.par_dim)

@property
def prec(self):
Expand Down
Loading