Fix GMRF not working with LinearRTO when scalar is passed as mean - #661
Draft
jeverink wants to merge 6 commits into
Draft
Fix GMRF not working with LinearRTO when scalar is passed as mean#661jeverink wants to merge 6 commits into
jeverink wants to merge 6 commits into
Conversation
Makes it correctly work with LinearRTO now
jeverink
marked this pull request as ready for review
June 20, 2025 13:29
amal-ghamdi
reviewed
Aug 21, 2025
amal-ghamdi
left a comment
amal-ghamdi
left a comment
Contributor
There was a problem hiding this comment.
Thank you @jeverink for the fix.
one comment: In general we try to support inferring length either from the geometry or from other mutable properties (mean and prec in this case). Can you expand the update to support this? for example if prec is an array, then dimension can be inferred from it.
Co-authored-by: amal-ghamdi <amal.m.alghamdi@gmail.com>
jeverink
marked this pull request as draft
September 2, 2025 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the mean of a GMRF to a vector of the correct length when a scalar is passed.
This is required for using the GMRF as a prior with the Linear RTO sampler.
Closes #627