You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pd_calib_xcoord - originally keyed on .id and .xcoord_overall_id (linked to _pd_calib_xcoord_overall.id). There was no way to link each point of the calibration to the detector it was calibrating. .xcoord_overall_id was demoted to linked non-key data item. .detector_id promoted to part of composite key. Updated the examples.
Just making sure I understand the logic here. An x-calibration, described in PD_CALIB_XCOORD_OVERALL has a globally unique identifier which identifies a diffractogram and phase used for the calibration. As neither phase nor diffractogram are keys, multiple calibrations could be listed that use the same source diffractogram and phase but go about it slightly differently. The particular calibration used is therefore indicated in the _pd_calib_xcoord.xcoord_overall_id data name. Via this calibration measurement we have the instrument and detector that is the target of calibration, so doesn't that mean we already have the detector_id without needing to restate it? I believe a detector should never be calibrated using a measurement from a different detector?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pd_calib_xcoord- originally keyed on.idand.xcoord_overall_id(linked to_pd_calib_xcoord_overall.id). There was no way to link each point of the calibration to the detector it was calibrating..xcoord_overall_idwas demoted to linked non-key data item..detector_idpromoted to part of composite key. Updated the examples.